U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@sigma-star.at>
To: Richard Weinberger <richard@nod.at>, upstream@sigma-star.at
Cc: u-boot@lists.denx.de, patrick.delaunay@foss.st.com,
	yangshiji66@outlook.com, raymond.mao@linaro.org, n-jain1@ti.com,
	eugeneuriev@gmail.com, ilias.apalodimas@linaro.org,
	devarsht@ti.com, bmeng.cn@gmail.com, trini@konsulko.com,
	upstream+uboot@sigma-star.at, Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH] reloc_bootstage: Fix out-of-bounds read
Date: Mon, 29 Jul 2024 23:57:19 +0200	[thread overview]
Message-ID: <12856391.hYdu0Ggh8K@somecomputer> (raw)
In-Reply-To: <CAFLszTg-bqTTv2NtVC-3m2O2nw+9eczcM9_wn41u6XMcujqNEQ@mail.gmail.com>

Simon,

Am Samstag, 13. Juli 2024, 17:13:50 CEST schrieb Simon Glass:
> Can you use 'bootstage' as the commit tag?

Sure.

> > +       debug("Copying bootstage from %p to %p\n", gd->bootstage,
> > +             gd->new_bootstage);
> > +       memcpy(gd->new_bootstage, gd->bootstage, sizeof(struct bootstage_data));
> 
> I would like to have the relocation addresses in board_f like with
> other relocations, so it is easy to see what is happening, in one
> file. So how about passing the old address to bootstage_relocate() so
> it doesn't need to access gd->new_bootstage ?

You mean passing the *new* address?

Thanks,
//richard

-- 
​​​​​sigma star gmbh | Eduard-Bodem-Gasse 6, 6020 Innsbruck, AUT
UID/VAT Nr: ATU 66964118 | FN: 374287y



  reply	other threads:[~2024-07-29 21:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-12  8:11 [PATCH] reloc_bootstage: Fix out-of-bounds read Richard Weinberger
2024-07-13 15:13 ` Simon Glass
2024-07-29 21:57   ` Richard Weinberger [this message]
2024-07-31 14:38     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12856391.hYdu0Ggh8K@somecomputer \
    --to=richard@sigma-star.at \
    --cc=bmeng.cn@gmail.com \
    --cc=devarsht@ti.com \
    --cc=eugeneuriev@gmail.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=n-jain1@ti.com \
    --cc=patrick.delaunay@foss.st.com \
    --cc=raymond.mao@linaro.org \
    --cc=richard@nod.at \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=upstream+uboot@sigma-star.at \
    --cc=upstream@sigma-star.at \
    --cc=yangshiji66@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox