From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 1/7] Expand POST memory test to support arch-depended implementation.
Date: Tue, 28 Sep 2010 10:55:12 -0700 [thread overview]
Message-ID: <1285696512.30239.14.camel@oslab-l1> (raw)
In-Reply-To: <20100928173130.CDDF9D52190@gemini.denx.de>
On Tue, 2010-09-28 at 19:31 +0200, Wolfgang Denk wrote:
> > -int memory_post_test (int flags)
> > +__attribute__((weak))
> > +int arch_memory_test_prepare(u32 *vstart, u32 *size, phys_addr_t *phys_offset)
>
> phys_offset is unused here. Drop it?
>
The phys_offset is not used by _this_ weak function but it is used by
another function implemented in the third patch. Is it OK to leave the
unused phys_offset here?
Regards,
York
next prev parent reply other threads:[~2010-09-28 17:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 16:38 [U-Boot] [PATCH V2 1/7] Expand POST memory test to support arch-depended implementation York Sun
2010-09-28 16:38 ` [U-Boot] [PATCH V2 2/7] Adding more control to physical address mapping York Sun
2010-09-28 17:33 ` Wolfgang Denk
2010-09-28 16:38 ` [U-Boot] [PATCH V2 3/7] Add memory test feature for mpc85xx POST York Sun
2010-09-28 17:38 ` Wolfgang Denk
2010-09-28 16:38 ` [U-Boot] [PATCH V2 4/7] Fix address for POST for 85xx with CPM York Sun
2010-09-28 16:38 ` [U-Boot] [PATCH V2 5/7] Setup POST word for generic mpc85xx York Sun
2010-09-28 16:38 ` [U-Boot] [PATCH V2 6/7] Enable POST memory test for corenet_ds York Sun
2010-09-28 16:38 ` [U-Boot] [PATCH V2 7/7] Enable POST memory test for P2020DS York Sun
2010-09-28 17:31 ` [U-Boot] [PATCH V2 1/7] Expand POST memory test to support arch-depended implementation Wolfgang Denk
2010-09-28 17:55 ` York Sun [this message]
2010-09-28 18:50 ` Wolfgang Denk
2010-09-28 19:24 ` York Sun
2010-09-28 19:44 ` Wolfgang Denk
2010-09-28 18:53 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285696512.30239.14.camel@oslab-l1 \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox