From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Tue, 27 Oct 2020 10:32:49 +0100 Subject: [PATCH 7/8] usb: ci_udc: Convert driver to DM_USB_GADGET In-Reply-To: References: <20201012062354.3743-1-peng.fan@nxp.com> <20201012062354.3743-8-peng.fan@nxp.com> <124751.1603784732@gemini.denx.de> <126171.1603786559@gemini.denx.de> Message-ID: <128591.1603791169@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Peng Fan, In message you wrote: > > > > > > > > +static const struct udevice_id ci_udc_otg_ids[] = { > > > > > + { .compatible = "fsl,imx27-usb-gadget" }, > > > > > + { } > > > > > +}; > > > > > > > > What is imx27-usb-gadget ? > > > > > > This U-Boot specific compatible string. I have no better idea what we > > > need use here to make DM driver work. > > > > But what is "imx27" ? This is a i.MX8M family platform, right? > > Not ancient i.MX27 ? > > This is just a compatible string means all controllers compatible with > i.MX27 USB could use this driver. > > Yes this is for i.MX8MM, but the usb gadget feature could reuse > the i.MX27 code. Maybe I'm missing something, but I cannot find imx27-usb-gadget being used anywhere - not in U-Boot nor in Linux mainline ? And if we introduce this completely new - then why imx27 ? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de If you think the problem is bad now, just wait until we've solved it. Epstein's Law