public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Steve Sakoman <steve@sakoman.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH RFC] ARMV7: OMAP: I2C driver: Reduce excessively long udelay calls
Date: Fri, 15 Oct 2010 12:48:57 -0700	[thread overview]
Message-ID: <1287172137.7756.72.camel@quadra> (raw)
In-Reply-To: <20101015192718.6340C1365CF@gemini.denx.de>

On Fri, 2010-10-15 at 21:27 +0200, Wolfgang Denk wrote:
> Dear Steve Sakoman,
> 
> In message <1287158873.7756.66.camel@quadra> you wrote:
> > I've been preparing a patch series for Beagle and Overo that detects expansion
> > board configuration information by reading a 128 byte I2C EEPROM on each
> > expansion board.
> > 
> > Using the OMAP I2C driver in its current form takes about 5-6 seconds to read
> > this small number of bytes!
> > 
> > Examining the code I see that there are a large number of fairly long udelay calls
> > throughout the driver (10 - 50 milliseconds). I looked through the linux driver
> > and did not see equivalent delays in that code.  In fact the longest delay in the
> > linux code was one millisecond.
> 
> Eventually the long delays are needed to make the code work stable
> even under rare conditions, which don't happen to often.  But this may
> be caused by the way the code is written, too...

<snip>

> My feeling is that this driver needs a more thorough rework.

Unfortunately I am inclined to agree with you!

I'll start work on that.

Steve

      reply	other threads:[~2010-10-15 19:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-15 16:07 [U-Boot] [PATCH RFC] ARMV7: OMAP: I2C driver: Reduce excessively long udelay calls Steve Sakoman
2010-10-15 19:27 ` Wolfgang Denk
2010-10-15 19:48   ` Steve Sakoman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1287172137.7756.72.camel@quadra \
    --to=steve@sakoman.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox