From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60C63C433EF for ; Thu, 11 Nov 2021 12:24:21 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3025460F59 for ; Thu, 11 Nov 2021 12:24:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3025460F59 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 726A683A15; Thu, 11 Nov 2021 13:24:17 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1636633457; bh=PsPBEUxmR99QhOtdHKZY1e1r9C/WWOdyU4k4sAnOiJc=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=oP7skj/eXz4oEjk/EvQZ7q1ZwNq/2ZWWaL8Sf5fU9nvtnEXEzBm+7yz+emq8gp8RB V7SaX1XOR43OrkaYAM5RNush8/YcCVt8SeSR0z5M8XzBzGeuwk5Pyp+/fYqXXYC9wk 1SmIV0O5CMPYkeIjM6+u2YblZdSRscJE1qfNNCWAktSZZ+YZD5xSStsI7pngcGFHUu SHPltQoFDmbPjtelDc1cgv7lR+bxLGZ0y7aqexSM3BcJLlRsLM0ukAoYdMXSjUSjCG w+m7d2b+/sWU4rRoQhi1TIIguDvPLwXbDn5gi+zNEL1OOHZCck1jkb+iYy8IFDIksk wcDZTriDoPDwQ== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id CAACD83A13 for ; Thu, 11 Nov 2021 13:24:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1636633455; bh=PsPBEUxmR99QhOtdHKZY1e1r9C/WWOdyU4k4sAnOiJc=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=g8y813vaJ0fXL+qkkeaFykHBOKZjBaxquugI8aXu4F3dvMhbR/Rw/A/zRo/VCaXJr l8xlyTn+qao0/y6hr6qSgiDOE5r9C5TGNBE/d1s6ec8YtNnZdTvu5XmcbAAZAel/Al LTxzpFc9SPB+WPVW/89IFo0a5XJ7JIMVtq17kG3Ew+PY+iJ2GGnwG4xic/n8L2fQ7v ZFfumwhymaLYZUeO8JCk+2HjQwtw+6tjLb8FaeUgD/m1olLyAz8qSsXQ1DwW93pGbO gLohw8RwplQGdpfCyB0iqCHYXN1AgH3y2kTdMOvFpGqk3Y3rlYG9vT+YDd6UavSL07 PjuIX4oQScvGA== Received: by janitor.denx.de (Postfix, from userid 108) id 86972A0236; Thu, 11 Nov 2021 13:24:15 +0100 (CET) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 23709A0040; Thu, 11 Nov 2021 13:24:06 +0100 (CET) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id EECB71E0CB7; Thu, 11 Nov 2021 13:24:05 +0100 (CET) To: Heiko Thiery cc: u-boot@lists.denx.de, Stefano Babic , Fabio Estevam , Michael Walle , Simon Glass From: Wolfgang Denk Subject: Re: [RFC 0/2] Do not stop with an error when mkimage fails MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: References: <20211104185231.2927-1-heiko.thiery@gmail.com> <729199.1636053161@gemini.denx.de> <963318.1636296486@gemini.denx.de> Comments: In-reply-to Heiko Thiery message dated "Tue, 09 Nov 2021 20:21:07 +0100." Date: Thu, 11 Nov 2021 13:24:05 +0100 Message-ID: <1288986.1636633445@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Heiko, In message you wrote: > > > Sorry, but this makes no sense to me. If there is an error, it > > should be reported and - if possible - handled. If this is not > > possible, then the correct thing is to abort. Ignoring errors and > > trying to continue is always the worst thing to do. > > The only reason I want to introduce this is because I want to have my > imx8mq board built by CI. This board needs an external HDMI firmware > which is used by mkimage. But because this firmware is not available > in the CI build, it comes to the abort. With other boards it is also > so that in the CI external blobs are not available and these make > nevertheless without error a binman run. In this case only a warning > is output. > > I know this is not a perfect solution but I don't know how to get my > board merged without doing this kind of workaround for the U-Boot CI. It's not only not a perfect solution, it is the intentional introduction of a bug, and thus totally unacceptable. If there is a file missing in the CI, then add/create it there. But do remove necessary error handling which would cause hard to detec failures when for normal use. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de The moral of the story is: "Don't stop to tighten your shoe laces during the Olympics 100m finals". - Kevin Jones in