From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AE2DC433F5 for ; Thu, 11 Nov 2021 12:27:35 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FEA261038 for ; Thu, 11 Nov 2021 12:27:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1FEA261038 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6333383A2A; Thu, 11 Nov 2021 13:27:32 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1636633652; bh=OEDa8NCuw6rFcdyohYNfdAMuGHzIH5MuqY7DZKt30OQ=; h=To:cc:From:Subject:In-reply-to:References:Date:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=w0glDcGnKWdqEVq9/I2c6pxt2k2/2Z7VoiSCd9Lr3U2rMMl5TsgV2s9ml2E3J1l8d S/nixAQxnKX1bz07MvKUF+y4sfUuuIGIEdRj9K6zjg6L5iWBtWRpZGANalXPjkH/Sx JYGoVlf/gJHfCh1slp8HPV6XINMzLeymVAMBz01mXCHGEs6NVfceZNRejmo7ICTu1W kdMcytJIYETTD8hCP8vxzpdaXbDW1f2oJveeLWrB9siAoFe0U1YUvcOpGfGfL6GWyL y8vRRh6fZiSbG0x0Xec1n/tDVROWntxw57v6I36g5/l48KzALZmbeEzNoSfc31LHR2 n+DcAYKcHVeDQ== Received: from janitor.denx.de (unknown [62.91.23.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: noc@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 2139E83A23 for ; Thu, 11 Nov 2021 13:27:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1636633650; bh=OEDa8NCuw6rFcdyohYNfdAMuGHzIH5MuqY7DZKt30OQ=; h=To:cc:From:Subject:In-reply-to:References:Date:From; b=XH4IYRvqysxsx1OmC6uBWy4VNwUu67icvKYv5py/F2059JJfvFVOYBPQReqzWy+nj KqOsyfMbkdKngJkRZOjuWS916ppCRBvS0SgQfSO95eJ9fSOqcaZ21TRF4fd5zhHy37 u0K134Ci333YL8qlXqfG/LNqQ451iqIm1214pobXdx/NYAEpIgr0NiapHpFpU9dM2k VTtXZyMeJOVPcFcbEU+hEwaVOsKji25cu3z2U7uorGTl3VgFbvfofMymCuRG1FocIV jaglQ4GzdR2CqzYWdioLp5WiAAuF6lIgS+cs1UO6YHKOahh38n2mCjmzJeRD+KVFYf 4COS79JaVG1AQ== Received: by janitor.denx.de (Postfix, from userid 108) id D0DACA02BB; Thu, 11 Nov 2021 13:27:29 +0100 (CET) Received: from gemini.denx.de (gemini.denx.de [10.4.0.2]) by janitor.denx.de (Postfix) with ESMTPS id 2D6DCA0040; Thu, 11 Nov 2021 13:27:22 +0100 (CET) Received: from gemini.denx.de (localhost [IPv6:::1]) by gemini.denx.de (Postfix) with ESMTP id 1C7A11E0CB7; Thu, 11 Nov 2021 13:27:22 +0100 (CET) To: Tom Rini cc: Heiko Thiery , u-boot@lists.denx.de, Stefano Babic , Fabio Estevam , Michael Walle , Simon Glass From: Wolfgang Denk Subject: Re: [RFC 0/2] Do not stop with an error when mkimage fails MIME-Version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8bit In-reply-to: <20211109194224.GB24579@bill-the-cat> References: <20211104185231.2927-1-heiko.thiery@gmail.com> <729199.1636053161@gemini.denx.de> <963318.1636296486@gemini.denx.de> <20211109194224.GB24579@bill-the-cat> Comments: In-reply-to Tom Rini message dated "Tue, 09 Nov 2021 14:42:24 -0500." Date: Thu, 11 Nov 2021 13:27:22 +0100 Message-ID: <1289506.1636633642@gemini.denx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Dear Tom, In message <20211109194224.GB24579@bill-the-cat> you wrote: > > > The only reason I want to introduce this is because I want to have my > > imx8mq board built by CI. This board needs an external HDMI firmware > > which is used by mkimage. But because this firmware is not available > > in the CI build, it comes to the abort. With other boards it is also > > so that in the CI external blobs are not available and these make > > nevertheless without error a binman run. In this case only a warning > > is output. ... > Unfortunately in these days of needing multiple inputs to create a > functional image and also needing to have CI be able to be at all > useful, what we do in many many many cases is yell loudly to the user > that the resulting file here will NOT work and why. So yes, some "yell > it won't work but not return non-zero exit status" is the norm. This is a terrible degradtion from standard programming style, then. > I would be very much open however to some way to handle this > differently. Some environment variable our tools check for and then > yell-but-succeed? Some other idea? I'm just thinking out loud here. Well, why not fix the root cause? Heiko writes that "an external HDMI firmware" is needed - so the fix is to provide one, or at least a dummy file which is good enough for the build to succeed. It should be trivial to create a dummy file in the CI context, no? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de "A little knowledge is a dangerous thing." - Doug Gwyn