public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] revert "tsec: Force TBI PHY to 1000Mbps full duplex in SGMII mode"
Date: Wed, 17 Nov 2010 09:49:32 -0600	[thread overview]
Message-ID: <1290008972.20072.73.camel@petert> (raw)
In-Reply-To: <20101117131429.9F55E14E646@gemini.denx.de>

Hi Zhao,

> In message <1289986984-2314-1-git-send-email-b26998@freescale.com> you wrote:
> > On P2020DS and MPC8572DS, the link to SGMII card which use Vitesse
> > VSC8234 PHY can't come up. Current TBI PHY settings(TBICR_SETTINGS)
> > for SGMII mode cause link problems.
> > 
> > Revert commit 46e91674fb4b6d06c6a4984c0b5ac7d9a16923f4, and fix it.

Based on my company's discussions with Freescale and Freescale's
appnotes I believe that the current implementation is correct.  I make
reference to some of this in the original patch:
http://old.nabble.com/-U-Boot---PATCH--tsec:-Force-TBI-PHY-to-1000Mbps-full-duplex-in-SGMII-mode-td26188785.html

We use Broadcom PHYs on our boards, which likely has something to do
with the discrepancies between the P2020DS/MPC8572DS vs the
XPedite5370/XPedite5500.  Unless you have additional information that
shows that in-band SGMII auto-negotiation does work per the spec I'd
prefer to keep the current tsec.c code and add
CONFIG_TSEC_TBICR_SETTINGS workarounds to the P2020DS (already done in
commit 90b5bf211b85eee10c34cbeb907ce381142b7c99?) and MPC8572DS.

Best,
Peter

  reply	other threads:[~2010-11-17 15:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17  9:43 [U-Boot] [PATCH] revert "tsec: Force TBI PHY to 1000Mbps full duplex in SGMII mode" Zhao Chenhui
2010-11-17 10:41 ` Mike Frysinger
2010-11-17 13:14 ` Wolfgang Denk
2010-11-17 15:49   ` Peter Tyser [this message]
2010-11-18  4:13     ` Li Yang-R58472
2010-11-18  5:01       ` Peter Tyser
2010-11-18  6:50         ` [U-Boot] [PATCH] revert "tsec: Force TBI PHY to 1000Mbps fullduplex " Li Yang-R58472
2010-11-18 15:34           ` Peter Tyser
2010-11-19  5:53             ` Li Yang
2010-11-20  0:01               ` Peter Tyser
2010-12-02  4:52         ` [U-Boot] [PATCH] revert "tsec: Force TBI PHY to 1000Mbps full duplex " Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290008972.20072.73.camel@petert \
    --to=ptyser@xes-inc.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox