From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Tyser Date: Wed, 17 Nov 2010 09:49:32 -0600 Subject: [U-Boot] [PATCH] revert "tsec: Force TBI PHY to 1000Mbps full duplex in SGMII mode" In-Reply-To: <20101117131429.9F55E14E646@gemini.denx.de> References: <1289986984-2314-1-git-send-email-b26998@freescale.com> <20101117131429.9F55E14E646@gemini.denx.de> Message-ID: <1290008972.20072.73.camel@petert> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Zhao, > In message <1289986984-2314-1-git-send-email-b26998@freescale.com> you wrote: > > On P2020DS and MPC8572DS, the link to SGMII card which use Vitesse > > VSC8234 PHY can't come up. Current TBI PHY settings(TBICR_SETTINGS) > > for SGMII mode cause link problems. > > > > Revert commit 46e91674fb4b6d06c6a4984c0b5ac7d9a16923f4, and fix it. Based on my company's discussions with Freescale and Freescale's appnotes I believe that the current implementation is correct. I make reference to some of this in the original patch: http://old.nabble.com/-U-Boot---PATCH--tsec:-Force-TBI-PHY-to-1000Mbps-full-duplex-in-SGMII-mode-td26188785.html We use Broadcom PHYs on our boards, which likely has something to do with the discrepancies between the P2020DS/MPC8572DS vs the XPedite5370/XPedite5500. Unless you have additional information that shows that in-band SGMII auto-negotiation does work per the spec I'd prefer to keep the current tsec.c code and add CONFIG_TSEC_TBICR_SETTINGS workarounds to the P2020DS (already done in commit 90b5bf211b85eee10c34cbeb907ce381142b7c99?) and MPC8572DS. Best, Peter