public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] tsec: Revert to setting TBICR_ANEG_ENABLE by default for SGMII
Date: Thu, 02 Dec 2010 10:50:12 -0600	[thread overview]
Message-ID: <1291308612.20072.447.camel@petert> (raw)
In-Reply-To: <1291266273-22612-1-git-send-email-galak@kernel.crashing.org>

Hi Kumar,

> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>

Acked-by: Peter Tyser <ptyser@xes-inc.com>
Tested-by: Peter Tyser <ptyser@xes-inc.com>

<snip>

> index e0a1fa4..9d87eaf 100644
> --- a/include/configs/xpedite537x.h
> +++ b/include/configs/xpedite537x.h
> @@ -375,6 +375,12 @@ extern unsigned long get_board_ddr_clk(unsigned long dummy);
>  #define CONFIG_MII_DEFAULT_TSEC	1	/* Allow unregistered phys */
>  #define CONFIG_ETHPRIME		"eTSEC2"

Would you mind adding a comment along the lines of the following to
xpedite537x.h and xpedite550x.h above the CONFIG_TSEC_TBICR_SETTINGS
define?:
/*
 * In-band SGMII auto-negotiation between TBI and BCM5482S PHY fails, force
 * 1000mbps SGMII link
 */

> +#define CONFIG_TSEC_TBICR_SETTINGS ( \
> +		TBICR_PHY_RESET \
> +		| TBICR_FULL_DUPLEX \
> +		| TBICR_SPEED1_SET \
> +		)
> +

Thanks,
Peter

  reply	other threads:[~2010-12-02 16:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-02  5:04 [U-Boot] [PATCH] tsec: Revert to setting TBICR_ANEG_ENABLE by default for SGMII Kumar Gala
2010-12-02 16:50 ` Peter Tyser [this message]
2010-12-03  0:20   ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291308612.20072.447.camel@petert \
    --to=ptyser@xes-inc.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox