public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Becky Bruce <beckyb@kernel.crashing.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 02/13] tqm85xx: create fixed_sdram() to do sdram setup
Date: Thu,  2 Dec 2010 17:45:28 -0600	[thread overview]
Message-ID: <1291333539-11884-3-git-send-email-beckyb@kernel.crashing.org> (raw)
In-Reply-To: <1291333539-11884-2-git-send-email-beckyb@kernel.crashing.org>

Also, change this code to use phys_size_t instead of long int.
Using common naming for this function will enable us to use the common
initdram() for 85xx going forward.  Other than the type change,
this is just a code rearrange.

Signed-off-by: Becky Bruce <beckyb@kernel.crashing.org>
---
 board/tqc/tqm85xx/sdram.c |   37 +++++++++++++++++++++++--------------
 1 files changed, 23 insertions(+), 14 deletions(-)

diff --git a/board/tqc/tqm85xx/sdram.c b/board/tqc/tqm85xx/sdram.c
index 503c5e5..260cd1c 100644
--- a/board/tqc/tqm85xx/sdram.c
+++ b/board/tqc/tqm85xx/sdram.c
@@ -65,6 +65,7 @@ sdram_conf_t ddr_cs_conf[] = {
 #define	N_DDR_CS_CONF (sizeof(ddr_cs_conf) / sizeof(ddr_cs_conf[0]))
 
 int cas_latency (void);
+static phys_size_t sdram_setup(int);
 
 /*
  * Autodetect onboard DDR SDRAM on 85xx platforms
@@ -73,7 +74,26 @@ int cas_latency (void);
  *       so this should be extended for other future boards
  *       using this routine!
  */
-long int sdram_setup (int casl)
+phys_size_t fixed_sdram(void)
+{
+	int casl = 0;
+	phys_size_t dram_size = 0;
+
+	casl = cas_latency();
+	dram_size = sdram_setup(casl);
+	if ((dram_size == 0) && (casl != CONFIG_DDR_DEFAULT_CL)) {
+		/*
+		 * Try again with default CAS latency
+		 */
+		printf("Problem with CAS lantency, using default CL %d/10!\n",
+		       CONFIG_DDR_DEFAULT_CL);
+		dram_size = sdram_setup(CONFIG_DDR_DEFAULT_CL);
+		puts("       ");
+	}
+	return dram_size;
+}
+
+static phys_size_t sdram_setup(int casl)
 {
 	int i;
 	volatile ccsr_ddr_t *ddr = (void *)(CONFIG_SYS_MPC85xx_DDR_ADDR);
@@ -376,8 +396,7 @@ long int sdram_setup (int casl)
 
 phys_size_t initdram (int board_type)
 {
-	long dram_size = 0;
-	int casl;
+	phys_size_t dram_size = 0;
 
 #if defined(CONFIG_DDR_DLL)
 	/*
@@ -407,17 +426,7 @@ phys_size_t initdram (int board_type)
 	}
 #endif
 
-	casl = cas_latency ();
-	dram_size = sdram_setup (casl);
-	if ((dram_size == 0) && (casl != CONFIG_DDR_DEFAULT_CL)) {
-		/*
-		 * Try again with default CAS latency
-		 */
-		printf ("Problem with CAS lantency, using default CL %d/10!\n",
-			CONFIG_DDR_DEFAULT_CL);
-		dram_size = sdram_setup (CONFIG_DDR_DEFAULT_CL);
-		puts ("       ");
-	}
+	dram_size = fixed_sdram();
 
 	return dram_size;
 }
-- 
1.6.0.6

  reply	other threads:[~2010-12-02 23:45 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-02 23:45 [U-Boot] [PATCH 00/13] Go to common initdram() on 85xx-based boards Becky Bruce
2010-12-02 23:45 ` [U-Boot] [PATCH 01/13] mpc8540eval: Split initdram() into initdram() and sdram_init() Becky Bruce
2010-12-02 23:45   ` Becky Bruce [this message]
2010-12-02 23:45     ` [U-Boot] [PATCH 03/13] mpc85xx/tlb.c: Allow platforms to specify wimge bits Becky Bruce
2010-12-02 23:45       ` [U-Boot] [PATCH 04/13] socrates: rename sdram_setup fixed_sdram() Becky Bruce
2010-12-02 23:45         ` [U-Boot] [PATCH 05/13] mpc8569mds: Remove unnecessary CONFIG_SYS_LBC_SDRAM_BASE definition Becky Bruce
2010-12-02 23:45           ` [U-Boot] [PATCH 06/13] PM854: rename CONFIG_SYS_LBC_SDRAM_BASE CONFIG_SYS_LBC_BASE Becky Bruce
2010-12-02 23:45             ` [U-Boot] [PATCH 07/13] PM856: Rename " Becky Bruce
2010-12-02 23:45               ` [U-Boot] [PATCH 08/13] SBC8560: #define CONFIG_SYS_LBC_NO_SDRAM_INIT Becky Bruce
2010-12-02 23:45                 ` [U-Boot] [PATCH 09/13] stxgp3: " Becky Bruce
2010-12-02 23:45                   ` [U-Boot] [PATCH 10/13] SBC8540: " Becky Bruce
2010-12-02 23:45                     ` [U-Boot] [PATCH 11/13] MPC8568/MPC8569: Remove CONFIG_DDR_DLL define Becky Bruce
2010-12-02 23:45                       ` [U-Boot] [PATCH 12/13] mpc85xx boards: initdram() cleanup/bugfix Becky Bruce
2010-12-02 23:45                         ` [U-Boot] [PATCH 13/13] 85xx boards: Rename CONFIG_DDR_DLL to CONFIG_SYS_FSL_ERRATUM_DDR_MSYNC_IN Becky Bruce
2010-12-03 16:09                         ` [U-Boot] [PATCH 12/13] mpc85xx boards: initdram() cleanup/bugfix Peter Tyser
2010-12-03 20:54                           ` [U-Boot] [PATCH 08/13] SBC8560: #define CONFIG_SYS_LBC_NO_SDRAM_INIT Becky Bruce
2010-12-03 21:22                             ` Peter Tyser
2010-12-03  2:26                 ` Timur Tabi
2010-12-03 20:44                   ` Becky Bruce
2010-12-03 21:48                     ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291333539-11884-3-git-send-email-beckyb@kernel.crashing.org \
    --to=beckyb@kernel.crashing.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox