From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Tyser <ptyser@xes-inc.com>
Date: Fri, 03 Dec 2010 10:09:06 -0600
Subject: [U-Boot] [PATCH 12/13] mpc85xx boards: initdram() cleanup/bugfix
In-Reply-To: <1291333539-11884-13-git-send-email-beckyb@kernel.crashing.org>
References: <1291333539-11884-1-git-send-email-beckyb@kernel.crashing.org>
	<1291333539-11884-2-git-send-email-beckyb@kernel.crashing.org>
	<1291333539-11884-3-git-send-email-beckyb@kernel.crashing.org>
	<1291333539-11884-4-git-send-email-beckyb@kernel.crashing.org>
	<1291333539-11884-5-git-send-email-beckyb@kernel.crashing.org>
	<1291333539-11884-6-git-send-email-beckyb@kernel.crashing.org>
	<1291333539-11884-7-git-send-email-beckyb@kernel.crashing.org>
	<1291333539-11884-8-git-send-email-beckyb@kernel.crashing.org>
	<1291333539-11884-9-git-send-email-beckyb@kernel.crashing.org>
	<1291333539-11884-10-git-send-email-beckyb@kernel.crashing.org>
	<1291333539-11884-11-git-send-email-beckyb@kernel.crashing.org>
	<1291333539-11884-12-git-send-email-beckyb@kernel.crashing.org>
	<1291333539-11884-13-git-send-email-beckyb@kernel.crashing.org>
Message-ID: <1291392546.20072.584.camel@petert>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Becky,

> +/* Common ddr init for non-corenet fsl 85xx platforms */
> +#ifndef CONFIG_FSL_CORENET
> +phys_size_t initdram(int board_type)
> +{
> +	phys_size_t dram_size = 0;
> +
> +	puts("Initializing\n");

Any chance we can remove the puts() above?  "DRAM:" is always printed
out directly before initdram is called, so I don't think the
"Initializing" message adds much benefit and slightly dirties the
output.  For reference:

I2C:   ready
DRAM:  Initializing
    DDR: 2 GiB (DDR2, 64-bit, CL=5, ECC on)
FLASH: Executed from FLASH1
FLASH: 256 MiB

vs

I2C:   ready
DRAM:  DDR: 2 GiB (DDR2, 64-bit, CL=5, ECC on)
FLASH: Executed from FLASH1
FLASH: 256 MiB

Otherwise it looked good.  I tested on the xpedite5170 that was a corner
case, and the xpedite5370 (mpc8572-based).

Acked-by: Peter Tyser <ptyser@xes-inc.com>
Tested-by: Peter Tyser <ptyser@xes-inc.com>