From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Tyser <ptyser@xes-inc.com>
Date: Fri, 03 Dec 2010 15:22:31 -0600
Subject: [U-Boot] [PATCH 08/13] SBC8560: #define
 CONFIG_SYS_LBC_NO_SDRAM_INIT
In-Reply-To: <1E61DA01-5F52-49E5-95AF-EC1961815CD3@kernel.crashing.org>
References: <1291333539-11884-1-git-send-email-beckyb@kernel.crashing.org>
	<1291333539-11884-2-git-send-email-beckyb@kernel.crashing.org>
	<1291333539-11884-3-git-send-email-beckyb@kernel.crashing.org>
	<1291333539-11884-4-git-send-email-beckyb@kernel.crashing.org>
	<1291333539-11884-5-git-send-email-beckyb@kernel.crashing.org>
	<1291333539-11884-6-git-send-email-beckyb@kernel.crashing.org>
	<1291333539-11884-7-git-send-email-beckyb@kernel.crashing.org>
	<1291333539-11884-8-git-send-email-beckyb@kernel.crashing.org>
	<1291333539-11884-9-git-send-email-beckyb@kernel.crashing.org>
	<1291333539-11884-10-git-send-email-beckyb@kernel.crashing.org>
	<1291333539-11884-11-git-send-email-beckyb@kernel.crashing.org>
	<1291333539-11884-12-git-send-email-beckyb@kernel.crashing.org>
	<1291333539-11884-13-git-send-email-beckyb@kernel.crashing.org>
	<1291392546.20072.584.camel@petert>
	<1E61DA01-5F52-49E5-95AF-EC1961815CD3@kernel.crashing.org>
Message-ID: <1291411351.20072.637.camel@petert>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, 2010-12-03 at 14:54 -0600, Becky Bruce wrote:
> On Dec 2, 2010, at 8:26 PM, Peter Tyser wrote:
> 
> > Hi Becky,
> > 
> >> +/* Common ddr init for non-corenet fsl 85xx platforms */
> >> +#ifndef CONFIG_FSL_CORENET
> >> +phys_size_t initdram(int board_type)
> >> +{
> >> +	phys_size_t dram_size = 0;
> >> +
> >> +	puts("Initializing\n");
> > 
> > Any chance we can remove the puts() above?  "DRAM:" is always printed
> > out directly before initdram is called, so I don't think the
> > "Initializing" message adds much benefit and slightly dirties the
> > output.  For reference:
> 
> That's fine with me.... does anybody object to this?  It's certainly easy to change this now.

I just noticed it now, but I'd also be in favor of getting rid of the
"DDR:" puts() at the end of initdram().  It doesn't add much value since
the specific DDR type is already printed out in board_add_ram_info().

Best,
Peter