From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steve Sakoman <steve@sakoman.com>
Date: Sat, 04 Dec 2010 06:43:33 -0800
Subject: [U-Boot] [RFC 1/3] tools/env: Default to the config specified
 in	FW_CONFIG_FILE
In-Reply-To: <4CFA1F0A.9010509@denx.de>
References: <1291436933-26861-1-git-send-email-steve@sakoman.com>
	<1291436933-26861-2-git-send-email-steve@sakoman.com>
	<4CFA1F0A.9010509@denx.de>
Message-ID: <1291473813.23352.27.camel@quadra>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Sat, 2010-12-04 at 11:59 +0100, Stefano Babic wrote:
> On 12/04/2010 05:28 AM, Steve Sakoman wrote:
> > From: Lo?c Minier <loic.minier@linaro.org>
> > 
> 
> Hi,
> 
> >  #if defined(CONFIG_FILE)
> > +	/* Default to the config file specified in FW_CONFIG_FILE */
> > +	char *config_file = getenv("FW_CONFIG_FILE");
> 
> What about to pass the configuration file on the command line instead of
> an environment variable ? Something like "fw_env -c /etc/fw_config", for
> example ? IMHO it is easier to understand and we can add documentation
> in the "help" message.

Good suggestion, I prefer that too.

Steve