From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steve Sakoman <steve@sakoman.com>
Date: Sat, 04 Dec 2010 06:44:24 -0800
Subject: [U-Boot] [RFC 1/3] tools/env: Default to the config specified
 in FW_CONFIG_FILE
In-Reply-To: <201012040534.57622.vapier@gentoo.org>
References: <1291436933-26861-1-git-send-email-steve@sakoman.com>
	<1291436933-26861-2-git-send-email-steve@sakoman.com>
	<201012040534.57622.vapier@gentoo.org>
Message-ID: <1291473864.23352.28.camel@quadra>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Sat, 2010-12-04 at 05:34 -0500, Mike Frysinger wrote:
> On Friday, December 03, 2010 23:28:51 Steve Sakoman wrote:
> > +	if (!config_file || !strlen(config_file)) {
> 
> strlen is a bad bad idea.  if you only want to see if it's non-empty, check 
> the first byte.

I'll correct this in the next revision.

Thanks for reviewing the code!

Steve