From: Kumar Gala <galak@kernel.crashing.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] fsl_esdhc: Use mmc_set_clock to set initial speed
Date: Wed, 15 Dec 2010 02:20:15 -0600 [thread overview]
Message-ID: <1292401217-21154-2-git-send-email-galak@kernel.crashing.org> (raw)
In-Reply-To: <1292401217-21154-1-git-send-email-galak@kernel.crashing.org>
From: Jerry Huang <Chang-Ming.Huang@freescale.com>
After booting the u-boot, and first using some SD card (such as Sandisk 2G SD
card), because the field 'clock' of struct mmc is zero, this will cause
the read transfer is always active and SDHC DATA line is always active,
therefore, driver can't handle the next command.
Therefore, we use mmc_set_clock to setup both the data structure and HW
to the initial clock speed of 400000Hz.
Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
drivers/mmc/fsl_esdhc.c | 2 +-
include/mmc.h | 1 +
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
index 57cd4ee..73d5cd3 100644
--- a/drivers/mmc/fsl_esdhc.c
+++ b/drivers/mmc/fsl_esdhc.c
@@ -398,7 +398,7 @@ static int esdhc_init(struct mmc *mmc)
esdhc_write32(®s->sysctl, SYSCTL_HCKEN | SYSCTL_IPGEN);
/* Set the initial clock speed */
- set_sysctl(mmc, 400000);
+ mmc_set_clock(mmc, 400000);
/* Disable the BRR and BWR bits in IRQSTAT */
esdhc_clrbits32(®s->irqstaten, IRQSTATEN_BRR | IRQSTATEN_BWR);
diff --git a/include/mmc.h b/include/mmc.h
index 9f94f42..cc4aa36 100644
--- a/include/mmc.h
+++ b/include/mmc.h
@@ -280,6 +280,7 @@ int mmc_register(struct mmc *mmc);
int mmc_initialize(bd_t *bis);
int mmc_init(struct mmc *mmc);
int mmc_read(struct mmc *mmc, u64 src, uchar *dst, int size);
+void mmc_set_clock(struct mmc *mmc, uint clock);
struct mmc *find_mmc_device(int dev_num);
int mmc_set_dev(int dev_num);
void print_mmc_devices(char separator);
--
1.7.2.3
next prev parent reply other threads:[~2010-12-15 8:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 8:20 [U-Boot] [PATCH 0/3] fsl_esdhc fixes Kumar Gala
2010-12-15 8:20 ` Kumar Gala [this message]
2010-12-15 8:20 ` [U-Boot] [PATCH 2/3] fsl_esdhc: Fix max clock frequency Kumar Gala
2010-12-15 8:20 ` [U-Boot] [PATCH 3/3] fsl_esdhc: Fix the voltage validation process Kumar Gala
2010-12-16 17:41 ` Stefano Babic
2010-12-16 17:41 ` [U-Boot] [PATCH 2/3] fsl_esdhc: Fix max clock frequency Stefano Babic
2010-12-16 17:40 ` [U-Boot] [PATCH 1/3] fsl_esdhc: Use mmc_set_clock to set initial speed Stefano Babic
2010-12-15 13:59 ` [U-Boot] [PATCH 0/3] fsl_esdhc fixes Kumar Gala
2010-12-16 17:38 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292401217-21154-2-git-send-email-galak@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox