From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] OMAP3: EVM: Convert omap3_evm_version to u32
Date: Sat, 18 Dec 2010 07:40:28 +0100 [thread overview]
Message-ID: <1292654428-19095-1-git-send-email-dirk.behme@gmail.com> (raw)
Convert the variable omap3_evm_version to u32 to work around
some broken linkers from older tool chains. E.g. CodeSourcery's
2009q1-203 ld 2.19.51.20090205. Without this, these linkers
stop linking 'omap3_evm' or at least issue a warning. Like
arm-none-linux-gnueabi-ld: section .bss [8003f5e0 -> 8007e337] overlaps section .rel.dyn [8003f5e0 -> 80044e57]
arm-none-linux-gnueabi-ld: section .dynsym [80044e58 -> 80044ef7] overlaps section.bss [8003f5e0 -> 8007e337]
arm-none-linux-gnueabi-ld: u-boot: section .bss vma 0x8003f5e0 overlaps previous sections
CC: Sanjeev Premi <premi@ti.com>
Signed-off-by: Dirk Behme <dirk.behme@googlemail.com>
---
For a discussion of this see
http://lists.denx.de/pipermail/u-boot/2010-December/083706.html
board/ti/evm/evm.c | 4 ++--
board/ti/evm/evm.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
Index: u-boot.git/board/ti/evm/evm.c
===================================================================
--- u-boot.git.orig/board/ti/evm/evm.c
+++ u-boot.git/board/ti/evm/evm.c
@@ -37,9 +37,9 @@
#include <asm/mach-types.h>
#include "evm.h"
-static u8 omap3_evm_version;
+static u32 omap3_evm_version;
-u8 get_omap3_evm_rev(void)
+u32 get_omap3_evm_rev(void)
{
return omap3_evm_version;
}
Index: u-boot.git/board/ti/evm/evm.h
===================================================================
--- u-boot.git.orig/board/ti/evm/evm.h
+++ u-boot.git/board/ti/evm/evm.h
@@ -45,7 +45,7 @@ enum {
OMAP3EVM_BOARD_GEN_2, /* EVM Rev >= Rev E */
};
-u8 get_omap3_evm_rev(void);
+u32 get_omap3_evm_rev(void);
#if defined(CONFIG_CMD_NET)
static void setup_net_chip(void);
next reply other threads:[~2010-12-18 6:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-18 6:40 Dirk Behme [this message]
2010-12-18 22:12 ` [U-Boot] [PATCH] OMAP3: EVM: Convert omap3_evm_version to u32 Wolfgang Denk
2010-12-18 22:33 ` Paulraj, Sandeep
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292654428-19095-1-git-send-email-dirk.behme@gmail.com \
--to=dirk.behme@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox