public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/4 V2] Add basic NVIDIA Tegra2 SoC support
Date: Fri, 14 Jan 2011 13:59:56 -0600	[thread overview]
Message-ID: <1295035196.29642.6471.camel@petert> (raw)
In-Reply-To: <1295025097-25680-1-git-send-email-twarren@nvidia.com>

Hi Tom,

On Fri, 2011-01-14 at 10:11 -0700, Tom Warren wrote:
> This series of patches adds preliminary/baseline support for NVIDIA's
> Tegra2 SoC.  Basic CPU (AVP), RAM and UART init are covered so that the
> system (Harmony or Seaboard) can boot to the U-Boot serial cmd prompt.
> 
> Further support (for Cortex-A9 CPU(s), USB, SD/MMC, etc.) to follow.
> 
> V2: Make changes based on feedback from Peter Tyser and Sandeep Paulraj.

If you didn't use all the feedback to the original patches, you should
state explicitly what you changed here, or respond to the original
comment email as to why they weren't made.  For example, I see you
didn't make the suggested change to use IO access functions, or allow
compiling out of support for UARTA and UARTD.  That should be made clear
somewhere (and the logic of why the changes weren't made) so that those
reviewing the patches know what changed between v1 and v2 and why.  As
is its unclear why the v1 comments weren't implemented, so they also
apply to this series.

Best,
Peter

  parent reply	other threads:[~2011-01-14 19:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-14 17:11 [U-Boot] [PATCH 0/4 V2] Add basic NVIDIA Tegra2 SoC support Tom Warren
2011-01-14 17:11 ` [U-Boot] [PATCH 1/4 V2] arm: Tegra2: " Tom Warren
2011-01-14 17:11 ` [U-Boot] [PATCH 2/4 V2] serial: Add Tegra2 serial port support Tom Warren
2011-01-14 17:11 ` [U-Boot] [PATCH 3/4 V2] arm: Tegra2: Add support for NVIDIA Harmony board Tom Warren
2011-01-14 17:11 ` [U-Boot] [PATCH 4/4 V2] arm: Tegra2: Add support for NVIDIA Seaboard board Tom Warren
2011-01-14 19:59 ` Peter Tyser [this message]
2011-01-14 20:41   ` [U-Boot] [PATCH 0/4 V2] Add basic NVIDIA Tegra2 SoC support Tom Warren
2011-01-14 21:36     ` Peter Tyser
2011-01-14 22:39       ` Tom Warren
2011-01-14 23:00         ` Albert ARIBAUD
2011-01-14 23:23           ` Peter Tyser
2011-01-15  0:01             ` Wolfgang Denk
2011-01-17 23:27         ` Wolfgang Denk
2011-01-17 23:27     ` Wolfgang Denk
2011-01-19 21:23       ` Tom Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295035196.29642.6471.camel@petert \
    --to=ptyser@xes-inc.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox