From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V5 2/4] serial: Add Tegra2 serial port support
Date: Fri, 21 Jan 2011 17:46:24 -0600 [thread overview]
Message-ID: <1295653584.29414.519.camel@petert> (raw)
In-Reply-To: <1295651217-32421-3-git-send-email-twarren@nvidia.com>
Hi Tom,
On Fri, 2011-01-21 at 16:06 -0700, Tom Warren wrote:
> Signed-off-by: Tom Warren <twarren@nvidia.com>
> ---
> Changes for V2:
> - Move serial driver to separate patch
>
> Changes for V5:
> - Move arch/arm/cpu/armv7/uart.c & board.h to drivers/serial and
> rename to serial_tegra2.c
> - Remove use of uart_num & UART_A/D in serial_tegra2, simplify code
>
> arch/arm/cpu/armv7/tegra2/Makefile | 2 +-
> arch/arm/cpu/armv7/tegra2/board.c | 2 +-
> arch/arm/cpu/armv7/tegra2/board.h | 58 ----------
> arch/arm/cpu/armv7/tegra2/uart.c | 216 ------------------------------------
> common/serial.c | 3 +-
> drivers/serial/Makefile | 1 +
> drivers/serial/serial_tegra2.c | 205 ++++++++++++++++++++++++++++++++++
> drivers/serial/serial_tegra2.h | 49 ++++++++
> include/serial.h | 3 +-
> 9 files changed, 261 insertions(+), 278 deletions(-)
> delete mode 100644 arch/arm/cpu/armv7/tegra2/board.h
> delete mode 100644 arch/arm/cpu/armv7/tegra2/uart.c
> create mode 100644 drivers/serial/serial_tegra2.c
> create mode 100644 drivers/serial/serial_tegra2.h
It looks like arch/arm/cpu/armv7/tegra2/board.h and
arch/arm/cpu/armv7/tegra2/uart.c are added in the first patch, then
moved in this patch. It'd be ideal to just add them once in the proper
location.
On a side note, if you pass "git format-patch" the -M and -C options it
will make pretty diffs that only show what lines changed during a move.
In the case that you do move files in the future its nice to use those
options to ease review.
<snip>
+void uart_init(void)
> +{
> + /* Init each UART - there may be more than 1 on a board/build */
> +#if (CONFIG_TEGRA2_ENABLE_UARTA)
> + init_uart();
> +#endif
> +#if (CONFIG_TEGRA2_ENABLE_UARTD)
> + init_uart();
> +#endif
> +}
How about:
#if defined(CONFIG_TEGRA2_ENABLE_UARTA) || defined(CONFIG_TEGRA2_ENABLE_UARTD)
init_uart();
#endif
Best,
Peter
next prev parent reply other threads:[~2011-01-21 23:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-21 23:06 [U-Boot] [PATCH V5 0/4] Add basic NVIDIA Tegra2 SoC support Tom Warren
2011-01-21 23:06 ` [U-Boot] [PATCH V5 1/4] arm: Tegra2: " Tom Warren
2011-01-24 18:58 ` Wolfgang Denk
2011-01-21 23:06 ` [U-Boot] [PATCH V5 2/4] serial: Add Tegra2 serial port support Tom Warren
2011-01-21 23:46 ` Peter Tyser [this message]
2011-01-24 17:32 ` Tom Warren
2011-01-24 17:51 ` Peter Tyser
2011-01-24 18:05 ` Tom Warren
2011-01-24 19:09 ` Wolfgang Denk
2011-01-24 19:14 ` Peter Tyser
2011-01-24 20:15 ` Tom Warren
2011-01-24 19:05 ` Wolfgang Denk
2011-01-25 8:11 ` Mike Rapoport
2011-01-25 16:50 ` Tom Warren
2011-01-25 21:12 ` Mike Rapoport
2011-01-25 21:37 ` Tom Warren
2011-01-25 22:11 ` Tom Warren
2011-01-25 22:24 ` Peter Tyser
2011-01-26 8:13 ` Mike Rapoport
2011-01-26 15:58 ` Peter Tyser
2011-01-27 7:54 ` Mike Rapoport
2011-01-26 17:05 ` Tom Warren
2011-01-27 7:41 ` Mike Rapoport
2011-01-27 16:08 ` Tom Warren
2011-01-21 23:06 ` [U-Boot] [PATCH V5 3/4] arm: Tegra2: Add support for NVIDIA Harmony board Tom Warren
2011-01-21 23:06 ` [U-Boot] [PATCH V5 4/4] arm: Tegra2: Add support for NVIDIA Seaboard board Tom Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295653584.29414.519.camel@petert \
--to=ptyser@xes-inc.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox