[U-Boot] [PATCH V5 2/4] serial: Add Tegra2 serial port support

Mike Rapoport
2011-01-27T07:54:43Z

On 01/26/11 17:58, Peter Tyser wrote:
> On Wed, 2011-01-26 at 10:13 +0200, Mike Rapoport wrote:
>> On 01/26/11 00:24, Peter Tyser wrote:
>
>> Moreover, I'd prefer to see pinmux_board_init or something similar that
>> configures all the pins at once rather than collection of pinmux_init_uart,
>> pinmux_init_sdmmc, pinmux_init_gmi etc that will grow as more drivers are added.
>
> I can see that point but its a different discussion. I don't know
> enough about the Tegra2 to comment on this, but it seems like a good
> idea based on previous experiences with boards with similar pinmuxing
> (eg mpc8260). In my last email I mentioned a table-driven approach
> (similar to the mpc8260 implementation?) which sounds somewhat like
> you're proposing.

Yes, I was thinking about table-driven approach, though slightly more
complicated than in mpc8260 :)
I think we can mostly reuse the Linux implementation of Tegra2 pinmux (1 and 2):
However, the pinmuxing API can be added after the basic Tegra2 support is
merged, IMO.

(1)
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=arch/arm/mach-tegra/pinmux.c;h=f80d507671bc1b22921ab2821c8a2cde427f1b5f;hb=HEAD
(2)
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=arch/arm/mach-tegra/pinmux-t2-tables.c;h=a6ea34e782dc339091b49e54871f953048651ad3;hb=HEAD

> Best,
> Peter
>

--
Sincerely yours,
Mike.