[U-Boot] [PATCH V5 2/4] serial: Add Tegra2 serial port support

Wolfgang Denk
2011-01-24T19:05:01Z

Dear Peter Tyser,

In message <1295891506.2045.146.camel@petert> you wrote:
>
> > I'll use those options in the future (thanks!) to keep things cleaner.
> > Hopefully we can just go with this set of patches so I can get to the
> > other, more interesting code (drivers, A9 CPU init, etc.).
>
> Its up to the ARM maintainer and Wolfgang to decide if adding code in
> one patch just to move it around in the 2nd is acceptable. I'm guess it

No, it is not acceptable. This should be fixed. Thanks for pointing
out.

> Also, just noticed:
> +static void init_uart(void)
> +{
> +#if CONFIG_TEGRA2_ENABLE_UARTA
> + uart_ctlr *const uart = (uart_ctlr *)NV_PA_APB_UARTA_BASE;
> +
> + uart_clock_init();
> +
> + /* Enable UARTA - uses config 0 */
> + pin_mux_uart();
> +
> + setup_uart(uart);
> +#endif /* CONFIG_TEGRA2_ENABLE_UARTD */
> +#if CONFIG_TEGRA2_ENABLE_UARTD
> + uart_ctlr *const uart = (uart_ctlr *)NV_PA_APB_UARTD_BASE;
> +
>
> Have you compiled with both UARTA and UARTD enabled? Redeclaring 'uart'
> in the middle of the function should throw an error or warning.

Even if the compiler should accept it (which I hpe not), then I will
not accept this ;-) Thanks for pointing out.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There is an old custom among my people. When a woman saves a man's
life, he is grateful.
-- Nona, the Kanuto which woman, "A Private Little War",
stardate 4211.8.