* [U-Boot] [PATCH] USB: Change the necessary defines to get debug output
@ 2011-01-28 11:42 Alexander Holler
2011-01-28 20:10 ` Remy Bohmer
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Holler @ 2011-01-28 11:42 UTC (permalink / raw)
To: u-boot
While debugging some USB stuff, I've first missed that there are actually
two defines necessary to get usefull output. The one needed to get debug output
for the communication with HUBs was burried somewhere deep inside the code.
Change that so that a #define DEBUG is enough while still leaving the possibility
to reduce unwanted debug output.
Signed-off-by: Alexander Holler <holler@ahsoftware.de>
---
common/usb.c | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/common/usb.c b/common/usb.c
index 10e23de..ee580ec 100644
--- a/common/usb.c
+++ b/common/usb.c
@@ -55,7 +55,10 @@
#include <asm/4xx_pci.h>
#endif
-#undef USB_DEBUG
+#ifdef DEBUG
+#define USB_DEBUG
+#define USB_HUB_DEBUG
+#endif
#ifdef USB_DEBUG
#define USB_PRINTF(fmt, args...) printf(fmt , ##args)
@@ -960,8 +963,6 @@ void usb_scan_devices(void)
* Probes device for being a hub and configurate it
*/
-#undef USB_HUB_DEBUG
-
#ifdef USB_HUB_DEBUG
#define USB_HUB_PRINTF(fmt, args...) printf(fmt , ##args)
#else
--
1.7.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] USB: Change the necessary defines to get debug output
2011-01-28 11:42 [U-Boot] [PATCH] USB: Change the necessary defines to get debug output Alexander Holler
@ 2011-01-28 20:10 ` Remy Bohmer
0 siblings, 0 replies; 2+ messages in thread
From: Remy Bohmer @ 2011-01-28 20:10 UTC (permalink / raw)
To: u-boot
Hi,
2011/1/28 Alexander Holler <holler@ahsoftware.de>:
> While debugging some USB stuff, I've first missed that there are actually
> two defines necessary to get usefull output. The one needed to get debug output
> for the communication with HUBs was burried somewhere deep inside the code.
>
> Change that so that a #define DEBUG is enough while still leaving the possibility
> to reduce unwanted debug output.
>
> Signed-off-by: Alexander Holler <holler@ahsoftware.de>
> ---
> ?common/usb.c | ? ?7 ++++---
> ?1 files changed, 4 insertions(+), 3 deletions(-)
Applied to u-boot-usb. Thanks.
Remy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-28 20:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-28 11:42 [U-Boot] [PATCH] USB: Change the necessary defines to get debug output Alexander Holler
2011-01-28 20:10 ` Remy Bohmer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox