From: Peter Tyser <ptyser@xes-inc.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V4 4/4] various cleanups/code style fixes
Date: Mon, 14 Mar 2011 09:46:12 -0500 [thread overview]
Message-ID: <1300113972.22456.1593.camel@petert> (raw)
In-Reply-To: <1299919532-7444-5-git-send-email-d.mueller@elsoft.ch>
Hi David,
It'd be good to include "smdk2410" in this patch titles, eg "smdk2410:
Various cleanups/code style fixes". or "arm: smdk2410: Various..."
Without the prefix, its unclear what code these patches affect, and
somewhat implies you are changing common code.
<snip>
> -#define CONFIG_RTC_S3C24X0 1
> +#define CONFIG_RTC_S3C24X0
Looks like there are a number of tabs in odd locations, it'd be nice to
clean those up while you're modifying this file.
Best,
Peter
next prev parent reply other threads:[~2011-03-14 14:46 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 15:43 [U-Boot] [PATCH] update SMDK2410 port David Müller
2011-01-11 7:41 ` [U-Boot] [PATCH V2] " David Müller
2011-01-11 9:38 ` Wolfgang Denk
2011-01-11 12:18 ` [U-Boot] [PATCH V3] " David Müller
2011-02-01 8:35 ` [U-Boot] [PING] " "David Müller (ELSOFT AG)"
2011-03-01 8:00 ` [U-Boot] [PING #2] " "David Müller (ELSOFT AG)"
2011-03-12 8:45 ` [U-Boot] [PATCH V4 0/4] " David Müller
2011-03-12 8:45 ` [U-Boot] [PATCH V4 1/4] activate ARM relocation feature David Müller
2011-03-12 8:45 ` [U-Boot] [PATCH V4 2/4] remove unneeded config.mk David Müller
2011-03-12 8:45 ` [U-Boot] [PATCH V4 3/4] use the CFI driver (and remove the old one) David Müller
2011-03-12 8:45 ` [U-Boot] [PATCH V4 4/4] various cleanups/code style fixes David Müller
2011-03-14 14:46 ` Peter Tyser [this message]
2011-03-17 12:35 ` [U-Boot] [PATCH V5 0/4] update SMDK2410 port David Müller
2011-03-17 12:35 ` [U-Boot] [PATCH V5 1/4] SMDK2410: activate ARM relocation feature David Müller
2011-03-22 0:24 ` Minkyu Kang
2011-03-22 8:44 ` "David Müller (ELSOFT AG)"
2011-03-22 8:45 ` Minkyu Kang
2011-03-22 8:56 ` "David Müller (ELSOFT AG)"
2011-03-17 12:35 ` [U-Boot] [PATCH V5 2/4] SMDK2410: remove unneeded config.mk David Müller
2011-03-22 0:26 ` Minkyu Kang
2011-03-22 8:44 ` "David Müller (ELSOFT AG)"
2011-03-22 8:54 ` Minkyu Kang
2011-03-22 9:37 ` "David Müller (ELSOFT AG)"
2011-03-24 2:58 ` Minkyu Kang
2011-03-17 12:35 ` [U-Boot] [PATCH V5 3/4] SMDK2410: use the CFI driver (and remove the old one) David Müller
2011-03-17 12:35 ` [U-Boot] [PATCH V5 4/4] SMDK2410: various cleanups/code style fixes David Müller
2011-03-25 8:28 ` [U-Boot] [PATCH V6 0/4] update SMDK2410 port David Müller
2011-03-25 8:28 ` [U-Boot] [PATCH V6 1/4] SMDK2410: activate ARM relocation feature David Müller
2011-04-08 2:25 ` Minkyu Kang
2011-03-25 8:28 ` [U-Boot] [PATCH V6 2/4] SMDK2410: remove unneeded config.mk David Müller
2011-04-08 2:26 ` Minkyu Kang
2011-03-25 8:28 ` [U-Boot] [PATCH V6 3/4] SMDK2410: use the CFI driver (and remove the old one) David Müller
2011-04-08 2:26 ` Minkyu Kang
2011-03-25 8:28 ` [U-Boot] [PATCH V6 4/4] SMDK2410: various cleanup/code style fixes David Müller
2011-04-08 2:27 ` Minkyu Kang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300113972.22456.1593.camel@petert \
--to=ptyser@xes-inc.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox