From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] mpc83xx: add config options to spd_sdram
Date: Thu, 7 Apr 2011 13:56:11 -0700 [thread overview]
Message-ID: <1302209771.19969.7.camel@oslab-l1> (raw)
In-Reply-To: <1427125824.654.1302208977309.JavaMail.open-xchange@proteus>
On Thu, 2011-04-07 at 22:42 +0200, Schwarz,Andre wrote:
> York,
>
>
>
>
> "Schwarz,Andre" <andre.schwarz@matrix-vision.de> hat am 6. April 2011
> um 20:42 geschrieben:
>
> > York,
> >
> >
> >
> > ok - will give it a try tomorrow.
> >
> >
> >
>
>
> hmm - having a look at the Makefile it looks like I need
> CONFIG_FSL_DDR2.
>
> This seems to pull in the "new" code ... without omitting the "old"
> one
>
> in arch/powerpc/cpu/mpc83xx/spd_sdram.c
>
>
>
> The Makefile further uses ctrl_regs.c ... which fails.
>
>
>
> having a look arch/powerpc/cpu/mpc8xxx/ddr/ctrl_regs.c gives :
>
>
>
> #ifdef CONFIG_MPC85xx
>
> #define _DDR_ADDR CONFIG_SYS_MPC85xx_DDR_ADDR
>
> #elif defined(CONFIG_MPC86xx)
>
> #define _DDR_ADDR CONFIG_SYS_MPC86xx_DDR_ADDR
>
> #else
>
> #error "Undefined _DDR_ADDR"
>
> #endif
>
>
>
> There's not a single sign of any 83xx within this code.
>
> Grepping through the board configs only show 85xx and 86xx based
> boards using it.
>
>
>
> Sorry, but I'm feeling like an idiot.
>
>
>
> Are you playing some game with me or am I simply unable to understand
> the code ?
>
>
>
> Please shed some light on this.
>
>
Andre,
I am sorry I totally ignored the subject with mpc83xx. I was thinking of
mpc85xx.
You are right the old code is in spd_sdram.c and it is still in use for
mpc83xx. Unless to adjust the code, there is no board specific file.
York
next prev parent reply other threads:[~2011-04-07 20:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 9:49 [U-Boot] [RFC] mpc83xx: add config options to spd_sdram Andre Schwarz
2011-04-05 21:52 ` Kim Phillips
2011-04-05 22:03 ` York Sun
2011-04-06 8:42 ` Andre Schwarz
2011-04-06 16:30 ` York Sun
2011-04-06 8:18 ` Andre Schwarz
2011-04-06 16:37 ` York Sun
2011-04-06 18:42 ` Schwarz, Andre
2011-04-07 20:42 ` Schwarz, Andre
2011-04-07 20:56 ` York Sun [this message]
2011-04-08 7:41 ` Andre Schwarz
2011-04-08 15:31 ` York Sun
2011-04-08 16:29 ` Andre Schwarz
2011-04-08 16:36 ` York Sun
2011-04-08 16:43 ` Andre Schwarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302209771.19969.7.camel@oslab-l1 \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox