From mboxrd@z Thu Jan 1 00:00:00 1970 From: York Sun Date: Thu, 7 Apr 2011 13:56:11 -0700 Subject: [U-Boot] [RFC] mpc83xx: add config options to spd_sdram In-Reply-To: <1427125824.654.1302208977309.JavaMail.open-xchange@proteus> References: <4D9AE5BD.704@matrix-vision.de> <20110405165227.78ecd5bd.kim.phillips@freescale.com> <4D9C21EA.3070005@matrix-vision.de> <1302107849.4586.14.camel@oslab-l1> <908840060.379.1302115339879.JavaMail.open-xchange@proteus> <1427125824.654.1302208977309.JavaMail.open-xchange@proteus> Message-ID: <1302209771.19969.7.camel@oslab-l1> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, 2011-04-07 at 22:42 +0200, Schwarz,Andre wrote: > York, > > > > > "Schwarz,Andre" hat am 6. April 2011 > um 20:42 geschrieben: > > > York, > > > > > > > > ok - will give it a try tomorrow. > > > > > > > > > hmm - having a look at the Makefile it looks like I need > CONFIG_FSL_DDR2. > > This seems to pull in the "new" code ... without omitting the "old" > one > > in arch/powerpc/cpu/mpc83xx/spd_sdram.c > > > > The Makefile further uses ctrl_regs.c ... which fails. > > > > having a look arch/powerpc/cpu/mpc8xxx/ddr/ctrl_regs.c gives : > > > > #ifdef CONFIG_MPC85xx > > #define _DDR_ADDR CONFIG_SYS_MPC85xx_DDR_ADDR > > #elif defined(CONFIG_MPC86xx) > > #define _DDR_ADDR CONFIG_SYS_MPC86xx_DDR_ADDR > > #else > > #error "Undefined _DDR_ADDR" > > #endif > > > > There's not a single sign of any 83xx within this code. > > Grepping through the board configs only show 85xx and 86xx based > boards using it. > > > > Sorry, but I'm feeling like an idiot. > > > > Are you playing some game with me or am I simply unable to understand > the code ? > > > > Please shed some light on this. > > Andre, I am sorry I totally ignored the subject with mpc83xx. I was thinking of mpc85xx. You are right the old code is in spd_sdram.c and it is still in use for mpc83xx. Unless to adjust the code, there is no board specific file. York