From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] mpc83xx: add config options to spd_sdram
Date: Fri, 8 Apr 2011 09:36:10 -0700 [thread overview]
Message-ID: <1302280570.7417.8.camel@oslab-l1> (raw)
In-Reply-To: <4D9F37EA.8030004@matrix-vision.de>
On Fri, 2011-04-08 at 18:29 +0200, Andre Schwarz wrote:
> York,
> > On Fri, 2011-04-08 at 09:41 +0200, Andre Schwarz wrote:
> >>> I am sorry I totally ignored the subject with mpc83xx. I was thinking of
> >>> mpc85xx.
> >> ok - no "new" code for 83xx then.
> >>> You are right the old code is in spd_sdram.c and it is still in use for
> >>> mpc83xx. Unless to adjust the code, there is no board specific file.
> >>>
> >> Are you willing to accept some changes to spd_sdram.c or will I have
> >> another out-of-tree board ?
> >>
> >> What we need is :
> >>
> >> - more configurable settings like driver strength, cpo and odt values.
> >> - Reading SPD data from an arbitrary i2c eeprom.
> >>
> >> What's so bad about my proposal ?
> >> Please let me know so that I'm able to improve.
> >>
> > I welcome the change to use the new code since the feature you asked is
> > already there.
> sorry, but I'm not sure if I understand this correctly.
>
> What I need is some minor non-intrusive changes to 83xx-specific file
> spd_sdram.c because it is the most straightforward solution with *no*
> impact on code size or other existing boards. So: The feature I ask for
> is *not* already there.
>
> What I definitely won't do is use the "new" fsl ddr code in mpc8xxx/ddr
> because it completely lacks 83xx support.
> So: The feature I ask for is there but my CPU family is not supported.
> IMHO the "new" code is total overkill for 83xx.
>
It would be easier to maintain one set of code. But if the change you
need is relatively small to the old code and doesn't have negative
impact on other boards, go ahead to post the patch.
York
next prev parent reply other threads:[~2011-04-08 16:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 9:49 [U-Boot] [RFC] mpc83xx: add config options to spd_sdram Andre Schwarz
2011-04-05 21:52 ` Kim Phillips
2011-04-05 22:03 ` York Sun
2011-04-06 8:42 ` Andre Schwarz
2011-04-06 16:30 ` York Sun
2011-04-06 8:18 ` Andre Schwarz
2011-04-06 16:37 ` York Sun
2011-04-06 18:42 ` Schwarz, Andre
2011-04-07 20:42 ` Schwarz, Andre
2011-04-07 20:56 ` York Sun
2011-04-08 7:41 ` Andre Schwarz
2011-04-08 15:31 ` York Sun
2011-04-08 16:29 ` Andre Schwarz
2011-04-08 16:36 ` York Sun [this message]
2011-04-08 16:43 ` Andre Schwarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302280570.7417.8.camel@oslab-l1 \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox