From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc/mpc8xxx: reword max tCKmin message
Date: Fri, 6 May 2011 06:45:08 +0800 [thread overview]
Message-ID: <1304635508.27474.11.camel@oslab-l1> (raw)
In-Reply-To: <4DC2BC72.90205@freescale.com>
On Thu, 2011-05-05 at 10:04 -0500, Timur Tabi wrote:
> Kumar Gala wrote:
> >>> >> That still needs some work, IMHO. I think you might need the word
> >>> >> "which" before "doesn't". However, even with that, it's not clear
> >>> >> what's wrong. Where does the bad value of "mclk_ps" come from?
> >>> >>
> >> >
> >> > It happens when the actually DDR clock is faster than the slowest DIMM
> >> > can support.
> >> >
> >> > York
> > Did you guys agree on wording? Is the patch ok or needs changing?
>
> I haven't seen an updated patch from York. I'd like to see the addition of text
> like, "It happens when the actually DDR clock is faster than the slowest DIMM
> can support." People need to know what to fix, not just what's wrong.
>
> Also, %d is for signed integers, not unsigned.
>
I will update the patch according to Timur's suggestion.
York
prev parent reply other threads:[~2011-05-05 22:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 1:51 [U-Boot] [PATCH] powerpc/mpc8xxx: reword max tCKmin message York Sun
2011-05-03 3:19 ` Tabi Timur-B04825
2011-05-03 3:40 ` York Sun
2011-05-05 14:09 ` Kumar Gala
2011-05-05 15:04 ` Timur Tabi
2011-05-05 22:45 ` York Sun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304635508.27474.11.camel@oslab-l1 \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox