From mboxrd@z Thu Jan  1 00:00:00 1970
From: York Sun <yorksun@freescale.com>
Date: Fri, 6 May 2011 06:45:08 +0800
Subject: [U-Boot] [PATCH] powerpc/mpc8xxx: reword max tCKmin message
In-Reply-To: <4DC2BC72.90205@freescale.com>
References: <1304387509-25357-1-git-send-email-yorksun@freescale.com>
	<BANLkTimdyjj3bGb5GFqLOaNTw5o7g5-y9w@mail.gmail.com>
	<1304394018.18283.42.camel@oslab-l1>
	<341138D6-917F-400E-BE08-73F9A6246AB9@kernel.crashing.org>
	<4DC2BC72.90205@freescale.com>
Message-ID: <1304635508.27474.11.camel@oslab-l1>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de


On Thu, 2011-05-05 at 10:04 -0500, Timur Tabi wrote:
> Kumar Gala wrote:
> >>> >> That still needs some work, IMHO.  I think you might need the word
> >>> >> "which" before "doesn't".  However, even with that, it's not clear
> >>> >> what's wrong.  Where does the bad value of "mclk_ps" come from?
> >>> >> 
> >> > 
> >> > It happens when the actually DDR clock is faster than the slowest DIMM
> >> > can support.
> >> > 
> >> > York
> > Did you guys agree on wording?  Is the patch ok or needs changing?
> 
> I haven't seen an updated patch from York.  I'd like to see the addition of text
> like, "It happens when the actually DDR clock is faster than the slowest DIMM
> can support."  People need to know what to fix, not just what's wrong.
> 
> Also, %d is for signed integers, not unsigned.
> 

I will update the patch according to Timur's suggestion.

York