public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] ARMV7: Vexpress: Add missing MMC header
Date: Mon, 23 May 2011 19:40:26 +0200	[thread overview]
Message-ID: <1306172426-17837-1-git-send-email-dirk.behme@gmail.com> (raw)

From: Dirk Behme <dirk.behme@googlemail.com>

Add a header file with the missing function prototype to fix

ca9x4_ct_vxp.c: In function 'cpu_mmc_init':
ca9x4_ct_vxp.c:93: warning: implicit declaration of function 'arm_pl180_mmci_init'

introduced by commit "ARMV7: Vexpress: Add MMC support"
(f0c64526b7e51ba997a0f1baf9e74e6d497b957e)

Signed-off-by: Dirk Behme <dirk.behme@googlemail.com>
CC: Andy Fleming <afleming@freescale.com>
CC: Matt Waddel <matt.waddel@linaro.org>

---

Changes in v2: Switch angle braces to quotes.

Note: Maybe it would be better to move

int arm_pl180_mmci_init(void);

from drivers/mmc/arm_pl180_mmci.h to a header in the
include directory?

 board/armltd/vexpress/ca9x4_ct_vxp.c |    1 +
 1 file changed, 1 insertion(+)

Index: u-boot.git/board/armltd/vexpress/ca9x4_ct_vxp.c
===================================================================
--- u-boot.git.orig/board/armltd/vexpress/ca9x4_ct_vxp.c
+++ u-boot.git/board/armltd/vexpress/ca9x4_ct_vxp.c
@@ -38,6 +38,7 @@
 #include <asm/arch/systimer.h>
 #include <asm/arch/sysctrl.h>
 #include <asm/arch/wdt.h>
+#include "../drivers/mmc/arm_pl180_mmci.h"
 
 static ulong timestamp;
 static ulong lastdec;

             reply	other threads:[~2011-05-23 17:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-23 17:40 Dirk Behme [this message]
2011-05-31 18:18 ` [U-Boot] [PATCH v2] ARMV7: Vexpress: Add missing MMC header Albert ARIBAUD
2011-05-31 18:41   ` Dirk Behme
2011-05-31 20:26     ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306172426-17837-1-git-send-email-dirk.behme@gmail.com \
    --to=dirk.behme@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox