[U-Boot] [PATCH 0/6] OMAP: fix build breaks on OMAP boards

Albert ARIBAUD
2011-06-08T20:20:53Z

Hi Aneesh,

Le 07/06/2011 17:13, Aneesh V a ?crit :
> Fix build breaks for OMAP boards.
> All the build breaks were due to couple of missing
> defines in the config file, namely:
>
> CONFIG_SYS_SDRAM_BASE and CONFIG_SYS_INIT_SP_ADDR
>
> They have been fixed by providing the right SDRAM
> base address and by using SRAM base as the initial
> stack address.
>
> None of these have been tested as I do not have any of
> these boards.
>
> Aneesh V (6):
> omap1610h2: fix build breaks
> omap5912osk: fix build breaks
> omap1510inn: fix build breaks
> omap1610inn: fix build breaks
> omap2420h4: fix build breaks
> omap730p2: fix build breaks
>
> include/configs/omap1510inn.h | 3 +++
> include/configs/omap1610h2.h | 3 +++
> include/configs/omap1610inn.h | 3 +++
> include/configs/omap2420h4.h | 3 +++
> include/configs/omap5912osk.h | 3 +++
> include/configs/omap730p2.h | 3 +++
> 6 files changed, 18 insertions(+), 0 deletions(-)

Could you post a V2 series with a symbolic constant rather than a magic
number for SP? Something like:

...
#define PHYS_SRAM 0x20000000
...
#define CONFIG_SYS_INIT_SP_ADDR PHYS_SRAM

... so that readers of the code know exactly that SP is set to SRAM base.

Amicalement,
--
Albert.