[U-Boot] [PATCH v3 04/10] armv7: replace CONFIG_L2_OFF with CONFIG_SYS_NO_L2CACHE

Aneesh V
2011-05-17T09:59:49Z

Hi Wolfgang,

On Monday 16 May 2011 12:23 AM, Wolfgang Denk wrote:
> Dear Aneesh V,
>
> In message<1305202276-27784-5-git-send-email-aneesh@ti.com> you wrote:
>> replace all occurences of CONFIG_L2_OFF with a more appropriate
>> CONFIG_SYS_NO_L2CACHE
>>
>> CONFIG_SYS_NO_L2CACHE has been chosen to be in line with
>> CONFIG_SYS_NO_ICACHE and CONFIG_SYS_NO_DCACHE
>
> sorry, but these are ugly mis-nomers. The situation is not that there
> is no cache present (which "NO_*CACHE" suggestes), but that the cache
> is (kept) turned off.
>
> CONFIG_SYS_L2CACHE_OFF is a _much_ better name than CONFIG_SYS_NO_L2CACHE.
>
> Please fix all these names.

Ok. Including the existing CONFIG_SYS_NO_DCACHE and
CONFIG_SYS_NO_ICACHE too, right?

best regards,
Aneesh