[U-Boot] [PATCH v3 03/10] armv7: cache maintenance operations for armv7

Aneesh V
2011-05-17T09:37:00Z

On Tuesday 17 May 2011 03:01 PM, Wolfgang Denk wrote:
> Dear Aneesh V,
>
> In message<4DD23D3A.4010001@ti.com> you wrote:
>>
>>> How much of this is actually needed in the context of U-Boot?
>>
>> Please see above. As far as I know OMAP doesn't do DMA in U-Boot.
>
> Devices like USB oth Ethernet don't use DMA for data transfers?
>
>>> Please do not add dead code. I consider it misleading to have
>>> functions which promise to perform something, and actually do nothing.
>>
>> These are empty only in the else part of an #ifdef. When cache support
>> is compiled out these need to be empty.
>
> When cache support is compiled out there should be no callers to these
> functions, so maybe they can disappear?

No, there may be callers in drivers. It will be ugly to keep all the
calls in various drivers under #ifdef, right? Is it not better to have
some empty functions and not worrying about the calls in various
places.

best regards,
Aneesh