[U-Boot] [PATCH v3 03/10] armv7: cache maintenance operations for armv7

Wolfgang Denk
2011-05-17T09:31:02Z

Dear Aneesh V,

In message <4DD23D3A.4010001@ti.com> you wrote:
>
> > How much of this is actually needed in the context of U-Boot?
>
> Please see above. As far as I know OMAP doesn't do DMA in U-Boot.

Devices like USB oth Ethernet don't use DMA for data transfers?

> > Please do not add dead code. I consider it misleading to have
> > functions which promise to perform something, and actually do nothing.
>
> These are empty only in the else part of an #ifdef. When cache support
> is compiled out these need to be empty.

When cache support is compiled out there should be no callers to these
functions, so maybe they can disappear?

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
No journaling file system can recover your data if the disk dies.
- Steve Rago in <D4Cw1p.L9E@plc.com>