public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kumar Gala <galak@kernel.crashing.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] powerpc/85xx: remove SERDES4 soft-reset work-around
Date: Thu, 30 Jun 2011 23:00:44 -0500	[thread overview]
Message-ID: <1309492845-13117-1-git-send-email-galak@kernel.crashing.org> (raw)

From: Timur Tabi <timur@freescale.com>

Some P4080 rev1 errata work-arounds, notably erratum SERDES4, required a
bank soft-reset after the bank was configured and enabled, even though enabling
a bank causes it to reset.  Because the reset was required for multiple errata,
it was not properly enclosed in an #ifdef, and so was not removed with all the
other rev1 errata work-arounds.

Because this was the only SERDES bank soft-reset, there is no need to implement
a work-around for erratum SERDES-A003.

Signed-off-by: Timur Tabi <timur@freescale.com>
---
 arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c b/arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c
index 741a0f8..e78d32d 100644
--- a/arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c
+++ b/arch/powerpc/cpu/mpc85xx/fsl_corenet_serdes.c
@@ -729,9 +729,6 @@ void fsl_serdes_init(void)
 		}
 #endif
 
-		/* reset banks for errata */
-		setbits_be32(&srds_regs->bank[bank].rstctl, SRDS_RSTCTL_RST);
-
 		wait_for_rstdone(bank);
 	}
 
-- 
1.7.3.4

             reply	other threads:[~2011-07-01  4:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-01  4:00 Kumar Gala [this message]
2011-07-01  4:00 ` [U-Boot] [PATCH 2/2] powerpc/85xx: Fix the work-arounds for errata SERDES-8 & SERDES-A001 on p4080 Kumar Gala
2011-07-01 12:43   ` Tabi Timur-B04825
2011-07-01 13:06     ` Kumar Gala
2011-07-01 14:06       ` Tabi Timur-B04825
2011-07-11 16:13         ` Kumar Gala
2011-10-06 22:13           ` Wolfgang Denk
2011-10-06 22:12   ` Wolfgang Denk
2011-10-06 22:15     ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1309492845-13117-1-git-send-email-galak@kernel.crashing.org \
    --to=galak@kernel.crashing.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox