public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@amd.com>
To: "Jae Hyun Yoo" <quic_jaehyoo@quicinc.com>,
	"Ovidiu Panait" <ovidiu.panait@windriver.com>,
	"Simon Glass" <sjg@chromium.org>,
	"Masahisa Kojima" <masahisa.kojima@linaro.org>,
	"Pali Rohár" <pali@kernel.org>,
	"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
	"Ashok Reddy Soma" <ashok.reddy.soma@xilinx.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Huang Jianan" <jnhuang95@gmail.com>,
	"Chris Morgan" <macromorgan@hotmail.com>,
	"Roland Gaudig" <roland.gaudig@weidmueller.com>,
	"Patrick Delaunay" <patrick.delaunay@foss.st.com>,
	"Alexandru Gagniuc" <mr.nuke.me@gmail.com>
Cc: "Jamie Iles" <quic_jiles@quicinc.com>,
	"Graeme Gregory" <quic_ggregory@quicinc.com>,
	"Cédric Le Goater" <clg@kaod.org>,
	u-boot@lists.denx.de
Subject: Re: [PATCH v1 0/2] cmd/fru: move FRU handling support to common region
Date: Mon, 1 Aug 2022 12:29:07 +0200	[thread overview]
Message-ID: <130afa99-eed6-a2e0-e265-ee0da363ca5d@amd.com> (raw)
In-Reply-To: <20220729215457.2697339-1-quic_jaehyoo@quicinc.com>



On 7/29/22 23:54, Jae Hyun Yoo wrote:
> Hello,
> 
> The FRU handling was added as a Xilinx board dependent support but it
> would be useful for other boards too, so this commit moves the FRU
> handling support to the common region so that it can be enabled by
> CONFIG_CMD_FRU.
> 
> To provide manufacturer specific custom board info field parsing,
> it defines 'fru_parse_board_custom' as a weak function so that it can
> be replaced with the board specific implementation. In the same way,
> OEM Multirecord type (0xc0 - 0xff) parsing logic can be replaced with
> a board specific 'fru_parse_multirec' implementation.
> 
> Also, this series adds 'Product Info' parsing support.
> 
> Please review!

In general I am fine with this but I want this to be done in steps to be able to 
better review it.
It means couple of preparation patches before this is moved to generic location.
Moving that part of xilinx private structure of board info as one step, 
multirecord OEM entries another one, etc.

Thanks,
Michal

  parent reply	other threads:[~2022-08-01 10:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-29 21:54 [PATCH v1 0/2] cmd/fru: move FRU handling support to common region Jae Hyun Yoo
2022-07-29 21:54 ` [PATCH v1 1/2] cmd: fru: " Jae Hyun Yoo
2022-08-01 12:34   ` Heinrich Schuchardt
2022-08-01 15:08     ` Jae Hyun Yoo
2022-07-29 21:54 ` [PATCH v1 2/2] cmd: fru: add product info area parsing support Jae Hyun Yoo
2022-08-01 12:37   ` Heinrich Schuchardt
2022-08-01 15:10     ` Jae Hyun Yoo
2022-08-01 10:29 ` Michal Simek [this message]
2022-08-01 14:56   ` [PATCH v1 0/2] cmd/fru: move FRU handling support to common region Jae Hyun Yoo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=130afa99-eed6-a2e0-e265-ee0da363ca5d@amd.com \
    --to=michal.simek@amd.com \
    --cc=ashok.reddy.soma@xilinx.com \
    --cc=clg@kaod.org \
    --cc=jnhuang95@gmail.com \
    --cc=macromorgan@hotmail.com \
    --cc=masahisa.kojima@linaro.org \
    --cc=mr.nuke.me@gmail.com \
    --cc=ovidiu.panait@windriver.com \
    --cc=pali@kernel.org \
    --cc=patrick.delaunay@foss.st.com \
    --cc=quic_ggregory@quicinc.com \
    --cc=quic_jaehyoo@quicinc.com \
    --cc=quic_jiles@quicinc.com \
    --cc=roland.gaudig@weidmueller.com \
    --cc=sjg@chromium.org \
    --cc=thuth@redhat.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox