From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EEEB4C00144 for ; Mon, 1 Aug 2022 10:30:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2337084488; Mon, 1 Aug 2022 12:30:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="B3GzJD7B"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8786C80330; Mon, 1 Aug 2022 12:30:11 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2055.outbound.protection.outlook.com [40.107.244.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7770D8414A for ; Mon, 1 Aug 2022 12:30:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RC++xroV5vOTXSuz4OjXX3ckDQvRX3vEnBzCxV2KUqLw8RzwBwIPvylUJuQMhO7IqtD0Rk61Euf4zvcHlBZ2vh3jvqaXNhrxHChcLNM4uQdDnPhZZ4HcTXzyJY9iMnfx9IrdVLWKPyJhD3w4o0utgK7CrKr1ZN1Re/eGQTdCntBAPS15A6KOYvIbsZesO/7vCtp/aSG4xrvZ0Xeblwc3kIQFH6qo3kHV6fseHpxV+J3dF7vmNXVG+otn2jdhkPZFVtm11wc++7vI03mf3wxnC+JQ1Bzpk2U0BqXpxhQPMpkoNO4gOZLg1V/X2Ye4A9r89dBwwnSadfDHFPELbKBmeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rZ20As83/yf2BEozpVwq00gZsLwOmVHE/gGn9bxk3c0=; b=l1wL886btTLUAofyoDIXYRe9csXhXNRM1XN577v3ZrOLNWd8BMTCNh19RgkqLupRLhGZd3jdFUw2HP7Y9Xsg65OSS8UylU6vz68jihzsNgprvM0wghuZVq+zxJNA1qSHoGKVWcWeGzc6TtUsl8mXg4HrtNX/Th3ubn9PXDyRYcH39g8pT7mcBpAmT5+8VhghzZ135A2VUApVEcL20kU2owKxWt0ZHsMxoJz6NeuxXEsCklDLsSvPwVr4fH+XOA8Dmm/y8l632+7xyUPePN1UJ5GXrn8WYFvhdLXYNwp90Czcxu7k5KyGJ/l54J1537tVWX+w5NTMpyLBgIzIKzvYJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=quicinc.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rZ20As83/yf2BEozpVwq00gZsLwOmVHE/gGn9bxk3c0=; b=B3GzJD7B3cVqQvGYh0U3r8qI0AvFMD80hYyo3Bxco7k5n7H+oAFsGrBKV4sUwYWqBBTqtsZ1SoKyqQLXBURLduimo0wLVMrYVlvlADD1xTXrLW96xdmO0VFDjlfIvhEbp3ts88bD/WMnc1P0s0ttLVjuRVVQEJG+X2xxf1Ar/qc= Received: from BN9PR03CA0906.namprd03.prod.outlook.com (2603:10b6:408:107::11) by BN6PR1201MB0228.namprd12.prod.outlook.com (2603:10b6:405:57::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.12; Mon, 1 Aug 2022 10:30:02 +0000 Received: from BN8NAM11FT018.eop-nam11.prod.protection.outlook.com (2603:10b6:408:107:cafe::d8) by BN9PR03CA0906.outlook.office365.com (2603:10b6:408:107::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.10 via Frontend Transport; Mon, 1 Aug 2022 10:30:02 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT018.mail.protection.outlook.com (10.13.176.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5482.10 via Frontend Transport; Mon, 1 Aug 2022 10:30:01 +0000 Received: from [10.254.241.52] (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 1 Aug 2022 05:29:52 -0500 Message-ID: <130afa99-eed6-a2e0-e265-ee0da363ca5d@amd.com> Date: Mon, 1 Aug 2022 12:29:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 0/2] cmd/fru: move FRU handling support to common region Content-Language: en-US To: Jae Hyun Yoo , Ovidiu Panait , Simon Glass , Masahisa Kojima , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Heinrich Schuchardt , Ashok Reddy Soma , Thomas Huth , Huang Jianan , Chris Morgan , Roland Gaudig , Patrick Delaunay , Alexandru Gagniuc CC: Jamie Iles , Graeme Gregory , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , References: <20220729215457.2697339-1-quic_jaehyoo@quicinc.com> From: Michal Simek In-Reply-To: <20220729215457.2697339-1-quic_jaehyoo@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 10cfadf2-9f3e-4b3b-ffe9-08da73a8caa7 X-MS-TrafficTypeDiagnostic: BN6PR1201MB0228:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xOIxz0+BAkc7YPC7b91xqNZ2GVt859GLhqqMymejQAUHG+hbKs7585XQo7Ggy2vXPC8+z3XmQ/w6qxmgxVC8TCPoIjlLudrELun+KXBAdPEkdHJQOS+ssAtVt7FaATrNzWK995yzfIAUp8MYaR4QlL5MEkKdd9HpnkPJliwpZ89Xxrt55RzlspQnAMW2uYPL44ErS4xLRmh8z3LGOlVKRn6eAK+AjY8wVwtdiUCQHBJZFfgJNGffXlLhOOEYCQjXkkLmrxiadu31f3Qg207GZBHPvqEX84lEHb0NbFo1YT0gtF3yUy5+lENzC8O6+gbLewM4aWiltPwczBqJuZVeQ2hmsdobWNHu2asPWlUexX0+4ciHGlU2/YhPeDwefqNtbzt3lXwALvCmBR032TRoX67XKEZ/qoYCEuDRSxvnLMJMEuyArrL8MG3vhY980B1LMJ9Yo/hbFcOyWfCNJsnUXSSADWXnzF1gtprikdf32HA6VSGO17gnq6EjKGwL1wKWJdi/j/7Jf5h85hvLzWarBcpOdSZL+fPzpMyyuPZ9kuqqRz2gdlOPKL990gXaNA8TvG62h6xm6R25QoONgUO3k+yAXMYk+7bQp46jmhY04ejMZBd72BHZov/HKWwR6isjJJbOgfehsgMRy5n4+/3ey0MhCzvbeph8vlhnswfz/w9Frvk2rNdEzYJaNKtQHBHj5OoEUyQ+K7C89s6OoDDroebJiB0HOjH3lHcDUE8sDB6Vbx3Q+qhjKW+P1HLd1Gch4De/D+v3Wj9gGJNfjcGRXVwXvRgfwvSbeBxFSmp4GIaJNGJUJNyBaFHCWtnjdkv09k44epr+7o+ySleowr7veimTwf0URmEyuNomCslomWrgAMSkh7HG+9CHSJdBeRpBEG46KOLbx4DgEg/SoeLTXA== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230016)(4636009)(376002)(39860400002)(396003)(346002)(136003)(36840700001)(40470700004)(7416002)(81166007)(5660300002)(32650700002)(82740400003)(6666004)(356005)(26005)(921005)(8936002)(40460700003)(41300700001)(426003)(336012)(31696002)(478600001)(86362001)(53546011)(36756003)(110136005)(54906003)(31686004)(40480700001)(2906002)(16576012)(70586007)(70206006)(4326008)(8676002)(316002)(82310400005)(2616005)(16526019)(186003)(44832011)(36860700001)(36900700001)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2022 10:30:01.7429 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 10cfadf2-9f3e-4b3b-ffe9-08da73a8caa7 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT018.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0228 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 7/29/22 23:54, Jae Hyun Yoo wrote: > Hello, > > The FRU handling was added as a Xilinx board dependent support but it > would be useful for other boards too, so this commit moves the FRU > handling support to the common region so that it can be enabled by > CONFIG_CMD_FRU. > > To provide manufacturer specific custom board info field parsing, > it defines 'fru_parse_board_custom' as a weak function so that it can > be replaced with the board specific implementation. In the same way, > OEM Multirecord type (0xc0 - 0xff) parsing logic can be replaced with > a board specific 'fru_parse_multirec' implementation. > > Also, this series adds 'Product Info' parsing support. > > Please review! In general I am fine with this but I want this to be done in steps to be able to better review it. It means couple of preparation patches before this is moved to generic location. Moving that part of xilinx private structure of board info as one step, multirecord OEM entries another one, etc. Thanks, Michal