public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] at91: reworked support for meesc board
Date: Thu, 04 Aug 2011 13:38:49 +0000	[thread overview]
Message-ID: <1312465129.31913.109.camel@ubuntu> (raw)
In-Reply-To: <4E2570D6.5030805@esd.eu>

Dear Matthias Fuchs,
> The meesc board support was broken. Within this opportunity, I completely
> reworked the board files.
> 
> Signed-off-by: Daniel Gorsulowski <Daniel.Gorsulowski@esd.eu>
> Signed-off-by: Matthias Fuchs <Matthias.Fuchs@esd.eu>
> ---
> V3: -fix white space issues and don't patch boards.cfg
> V2: -fixed commit description
> 
>  board/esd/meesc/config.mk |    1 -
>  board/esd/meesc/meesc.c   |   49 ++++++-----
>  include/configs/meesc.h   |  208 ++++++++++++++++++++++++++-------------------
>  3 files changed, 147 insertions(+), 111 deletions(-)
>  delete mode 100644 board/esd/meesc/config.mk

Sorry, this patch had escaped my sight.
Checkpatch has the following issues:

WARNING: Use #include <linux/io.h> instead of <asm/io.h>
#53: FILE: board/esd/meesc/meesc.c:30:
+#include <asm/io.h>
--> ignored

WARNING: please, no space for starting a line, 
				excluding comments
#334: FILE: include/configs/meesc.h:134:
+ /* DataFlash */$
--> fixed before applying

ERROR: Macros with complex values should be enclosed in parenthesis
#369: FILE: include/configs/meesc.h:157:
+# define CONFIG_SYS_NAND_ENABLE_PIN		AT91_PIO_PORTD, 15
ERROR: Macros with complex values should be enclosed in parenthesis
#370: FILE: include/configs/meesc.h:158:
+# define CONFIG_SYS_NAND_READY_PIN		AT91_PIO_PORTA, 22
--> both not nice style, but understandable als long as gpio routines
have 2 parameters (port and bit).

Configuring for meesc - Board: meesc, Options:
AT91SAM9263,SYS_USE_NANDFLASH
   text	   data	    bss	    dec	    hex	filename
 201434	   5304	  74688	 281426	  44b52	./u-boot

Configuring for meesc_dataflash - Board: meesc, Options:
AT91SAM9263,SYS_USE_DATAFLASH
   text	   data	    bss	    dec	    hex	filename
 207303	   5472	  75096	 287871	  4647f	./u-boot

"[U-Boot,41/52] ARM: remove broken "meesc" board" set to "not
applicable"

Thanks, Reinhard

      reply	other threads:[~2011-08-04 13:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-19 11:56 [U-Boot] [PATCH] at91: reworked support for meesc board Matthias Fuchs
2011-08-04 13:38 ` Reinhard Meyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312465129.31913.109.camel@ubuntu \
    --to=u-boot@emk-elektronik.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox