From mboxrd@z Thu Jan 1 00:00:00 1970 From: Reinhard Meyer Date: Thu, 04 Aug 2011 13:38:49 +0000 Subject: [U-Boot] [PATCH] at91: reworked support for meesc board In-Reply-To: <4E2570D6.5030805@esd.eu> References: <4E2570D6.5030805@esd.eu> Message-ID: <1312465129.31913.109.camel@ubuntu> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Matthias Fuchs, > The meesc board support was broken. Within this opportunity, I completely > reworked the board files. > > Signed-off-by: Daniel Gorsulowski > Signed-off-by: Matthias Fuchs > --- > V3: -fix white space issues and don't patch boards.cfg > V2: -fixed commit description > > board/esd/meesc/config.mk | 1 - > board/esd/meesc/meesc.c | 49 ++++++----- > include/configs/meesc.h | 208 ++++++++++++++++++++++++++------------------- > 3 files changed, 147 insertions(+), 111 deletions(-) > delete mode 100644 board/esd/meesc/config.mk Sorry, this patch had escaped my sight. Checkpatch has the following issues: WARNING: Use #include instead of #53: FILE: board/esd/meesc/meesc.c:30: +#include --> ignored WARNING: please, no space for starting a line, excluding comments #334: FILE: include/configs/meesc.h:134: + /* DataFlash */$ --> fixed before applying ERROR: Macros with complex values should be enclosed in parenthesis #369: FILE: include/configs/meesc.h:157: +# define CONFIG_SYS_NAND_ENABLE_PIN AT91_PIO_PORTD, 15 ERROR: Macros with complex values should be enclosed in parenthesis #370: FILE: include/configs/meesc.h:158: +# define CONFIG_SYS_NAND_READY_PIN AT91_PIO_PORTA, 22 --> both not nice style, but understandable als long as gpio routines have 2 parameters (port and bit). Configuring for meesc - Board: meesc, Options: AT91SAM9263,SYS_USE_NANDFLASH text data bss dec hex filename 201434 5304 74688 281426 44b52 ./u-boot Configuring for meesc_dataflash - Board: meesc, Options: AT91SAM9263,SYS_USE_DATAFLASH text data bss dec hex filename 207303 5472 75096 287871 4647f ./u-boot "[U-Boot,41/52] ARM: remove broken "meesc" board" set to "not applicable" Thanks, Reinhard