From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07EC9C4167B for ; Fri, 11 Nov 2022 15:28:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8BEC7850E2; Fri, 11 Nov 2022 16:28:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="ar0Z1B5V"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BBECA84E00; Fri, 11 Nov 2022 16:28:52 +0100 (CET) Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 139E5850E2 for ; Fri, 11 Nov 2022 16:28:49 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=detlev.casanova@collabora.com Received: from falcon9.localnet (mtl.collabora.ca [66.171.169.34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: detlev) by madras.collabora.co.uk (Postfix) with ESMTPSA id E4168660165C; Fri, 11 Nov 2022 15:28:47 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1668180528; bh=q4iy2tuJ/FSRVWfCoBhkZq2yAT5no1YJPHnQVqlxpF0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ar0Z1B5V6mGWBw63Zgjx742dFuU9KahHwTlzHKfBFCKwPsmpBz09qTjNxFXq/Z1N6 80FbPZpEyb14AHcwzqOYaAyLxiUhHi8EQwPnl7p6HO5VpeQ0/89CHEdPyQ92T52anc qPvAE1TlevvRWnjT/OALKEwod3OSghyRfreKNg6Q3oWB9yDr0RVoaaxwlRz/aYxNO/ dE6hFv/5Hq0twsjzhang2+W8VXpSjKPztj39OhEVuth5DvY+LOQSf67yhPzwUtIw9L L0CpNyVF50Xu9/02ec3mmBZ2DuDAQ+MU/50H82OhzdO6ZVBqTeTjUqEquymLIHRNdU xwFiiej8B0nOQ== From: Detlev Casanova To: Tom Rini Cc: u-boot@lists.denx.de, Stefano Babic , Fabio Estevam , "NXP i . MX U-Boot Team" Subject: Re: [PATCH] dts: Re-add aliases for imx6qdl-sabrelite devices Date: Fri, 11 Nov 2022 10:28:43 -0500 Message-ID: <13125638.O9o76ZdvQC@falcon9> In-Reply-To: <20221027183051.GN2020586@bill-the-cat> References: <20221027152252.46552-1-detlev.casanova@collabora.com> <20221027183051.GN2020586@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit X-Content-Filtered-By: Mailman/MimeDel 2.1.39 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Thursday, October 27, 2022 2:30:51 P.M. EST Tom Rini wrote: > On Thu, Oct 27, 2022 at 11:22:52AM -0400, Detlev Casanova wrote: > > In commit d0399a46e7cda63c07e3eb8558bef84cfb068028, the device tree was > > synchronized from linux and the aliases were dropped. > > > > They need to be kept so that the mmc cards are in the right order. > > Without the aliases, u-boot reports: > > MMC: FSL_SDHC: 2, FSL_SDHC: 3 > > > > With the aliases, u-boot reports: > > MMC: FSL_SDHC: 0, FSL_SDHC: 1 > > > > Signed-off-by: Detlev Casanova > > --- > > > > arch/arm/dts/imx6qdl-sabrelite.dtsi | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/arm/dts/imx6qdl-sabrelite.dtsi > > b/arch/arm/dts/imx6qdl-sabrelite.dtsi index 22f8e2783c..6564e3b82c 100644 > > --- a/arch/arm/dts/imx6qdl-sabrelite.dtsi > > +++ b/arch/arm/dts/imx6qdl-sabrelite.dtsi > > @@ -10,6 +10,13 @@ > > > > #include > > > > / { > > > > + aliases { > > + mmc0 = &usdhc3; > > + mmc1 = &usdhc4; > > + pwm_lcd = &pwm1; > > + pwm_lvds = &pwm4; > > + }; > > + > > > > chosen { > > > > stdout-path = &uart2; > > > > }; > > This really belongs in the upstream dts file so they aren't lost again > and again. Forwaded to upstream kernel: https://lore.kernel.org/lkml/20221028141811.101122-1-detlev.casanova@collabora.com/[1] Would it make sense to still add this one in u-boot before the devices trees are copied again ? Detlev. -------- [1] https://lore.kernel.org/lkml/20221028141811.101122-1-detlev.casanova@collabora.com/