From: Reinhard Meyer <u-boot@emk-elektronik.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] MAKEALL ARM: Use boards.cfg
Date: Fri, 05 Aug 2011 20:40:50 +0000 [thread overview]
Message-ID: <1312576850.31913.190.camel@ubuntu> (raw)
In-Reply-To: <1312568442-6043-1-git-send-email-dirk.behme@gmail.com>
Dear Dirk Behme,
> From: Dirk Behme <dirk.behme@googlemail.com>
>
> Use the boards from boards.cfg for building ./MAKEALL ARMx.
>
> Note: ARM10 systems don't seem to exist any more.
Wrong: a simple grep shows that those are still in Makefile.
>
> Signed-off-by: Dirk Behme <dirk.behme@googlemail.com>
>
> ---
> Changes in v2: Instead of dublicating the missing boards from
> boards.cfg to MAKEALL, use the boards defined in boards.cfg
> directly.
This sentence does not make sense to me...
How can something that is missing be duplicated?
I think you were wanting to say: "remove all boards that are in
boards.cfg from MAKEALL"
>
> MAKEALL | 134 ++++------------------------------------------------------------
> 1 file changed, 9 insertions(+), 125 deletions(-)
Are all those boards removed here in boards.cfg?
Answer: NO
Are none of them still in Makefile?
Answer: NO
Remember:
1. boards must either be in Makefile OR boards.cfg
2. boards that are still in Makefile MUST BE in MAKEALL
3. boards that are in boards.cfg SHOULD NOT be in MAKEALL
Of the boards removed from MAKEALL by your patch, I found several in
Makefile but not in boards.cfg.
By removing them from MAKEALL they will not be built any more in MAKEALL
runs and this would hide their possible brokenness!
Best Regards,
Reinhard
prev parent reply other threads:[~2011-08-05 20:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-05 18:20 [U-Boot] [PATCH v2] MAKEALL ARM: Use boards.cfg Dirk Behme
2011-08-05 20:40 ` Reinhard Meyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312576850.31913.190.camel@ubuntu \
--to=u-boot@emk-elektronik.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox