From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yao Cheng Date: Mon, 8 Aug 2011 21:57:58 +0800 Subject: [U-Boot] [PATCH v2] Fix wrong loop bound in flush_cache() when "size" is zero Message-ID: <1312811878-4535-1-git-send-email-saturdaycoder@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de The issue is found when calling flush_cache() with zero "size" argument. The bound of loop is miscalculated in this case and flush_cache() enters a wrong flushing loop. To fix this issue I skipped the operations when "size" is found to be zero. Signed-off-by: Yao Cheng Cc: Shinya Kuribayashi --- Changes for v2: - Coding style cleanup - Move code after declarations to avoid warning arch/mips/cpu/mips32/cpu.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/arch/mips/cpu/mips32/cpu.c b/arch/mips/cpu/mips32/cpu.c index 3ae397c..8fa53ba 100644 --- a/arch/mips/cpu/mips32/cpu.c +++ b/arch/mips/cpu/mips32/cpu.c @@ -56,6 +56,11 @@ void flush_cache(ulong start_addr, ulong size) unsigned long addr = start_addr & ~(lsize - 1); unsigned long aend = (start_addr + size - 1) & ~(lsize - 1); + /* aend will be miscalculated when size is zero, so we return here */ + if (size == 0) { + return; + } + while (1) { cache_op(Hit_Writeback_Inv_D, addr); cache_op(Hit_Invalidate_I, addr); -- 1.7.4.1