From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [u-boot-release] [Patch v3] powerpc/eeprom: cleanup mac command
Date: Thu, 11 Aug 2011 10:03:22 -0500 [thread overview]
Message-ID: <1313075002.5224.15.camel@oslab-l1> (raw)
In-Reply-To: <4E43ED71.4020304@freescale.com>
On Thu, 2011-08-11 at 09:55 -0500, Tabi Timur-B04825 wrote:
> York Sun wrote:
> > - e.mac_count = simple_strtoul(argv[2], NULL, 16);
> > + e.mac_count = simple_strtoul(argv[2], NULL, 10);
>
> You forgot the MAC address index. There's another use of strtoul in the
> code that needs to be fixed.
I didn't forget the index. It is base 10 already.
>
> Also, if you use "0" instead of "10", then it should be able to handle
> hex as well, just in case someone wants to use it.
That's not a bad idea. I will change to "0" but leave the mac address as
hex.
York
next prev parent reply other threads:[~2011-08-11 15:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-11 14:48 [U-Boot] [Patch v3] powerpc/eeprom: cleanup mac command York Sun
2011-08-11 14:55 ` [U-Boot] [u-boot-release] " Tabi Timur-B04825
2011-08-11 15:03 ` York Sun [this message]
2011-08-11 18:40 ` Tabi Timur-B04825
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313075002.5224.15.camel@oslab-l1 \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox