public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Joel A Fernandes <agnel.joel@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/7] led: correct off/on locations in structure
Date: Mon, 15 Aug 2011 21:42:04 -0500	[thread overview]
Message-ID: <1313462527-3876-4-git-send-email-agnel.joel@gmail.com> (raw)
In-Reply-To: <1313462527-3876-1-git-send-email-agnel.joel@gmail.com>

From: Jason Kridner <jkridner@beagleboard.org>

Although the initialization should probably be done with names, the
existing implementation has these structures filled in the opposite
order.

Signed-off-by: Jason Kridner <jkridner@beagleboard.org>
Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
Signed-off-by: Joel A Fernandes <agnel.joel@gmail.com>
---
 common/cmd_led.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/cmd_led.c b/common/cmd_led.c
index 8b46848..d14dd5a 100644
--- a/common/cmd_led.c
+++ b/common/cmd_led.c
@@ -34,8 +34,8 @@
 struct led_tbl_s {
 	char		*string;	/* String for use in the command */
 	led_id_t	mask;		/* Mask used for calling __led_set() */
-	void		(*on)(void);	/* Optional fucntion for turning LED on */
-	void		(*off)(void);	/* Optional fucntion for turning LED on */
+	void		(*off)(void);	/* Optional function for turning LED off */
+	void		(*on)(void);	/* Optional function for turning LED on */
 };
 
 typedef struct led_tbl_s led_tbl_t;
-- 
1.7.1

  parent reply	other threads:[~2011-08-16  2:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-16  2:42 [U-Boot] [PATCH 1/7] Corrected LED name match finding avoiding extraneous Usage printouts Joel A Fernandes
2011-08-16  2:42 ` [U-Boot] [PATCH 2/7] BeagleBoard: fix LED 0/1 in driver Joel A Fernandes
2011-08-16  2:42 ` [U-Boot] [PATCH 3/7] led: added cmd_led to Makefile Joel A Fernandes
2011-08-16  2:42 ` Joel A Fernandes [this message]
2011-08-16  2:42 ` [U-Boot] [PATCH 5/7] led: Fixed setting of STATUS_LED_BIT1 when led_name is 'all' Joel A Fernandes
2011-08-16 11:14   ` Sergei Shtylyov
2011-08-16 23:40     ` Joel A Fernandes
2011-08-16  2:42 ` [U-Boot] [PATCH 6/7] OMAP3: Add function to get state of a GPIO output Joel A Fernandes
2011-08-16  2:42 ` [U-Boot] [PATCH 7/7] led: Remove state-saving of led for toggle functionality and add toggle option to led command Joel A Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313462527-3876-4-git-send-email-agnel.joel@gmail.com \
    --to=agnel.joel@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox