From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/7] powerpc/mpc83xx: Migrate from spd_sdram to unified DDR driver
Date: Fri, 26 Aug 2011 11:15:29 -0700 [thread overview]
Message-ID: <1314382529.20734.34.camel@oslab-l1> (raw)
In-Reply-To: <20110826181259.6A0FD11F9E57@gemini.denx.de>
On Fri, 2011-08-26 at 20:12 +0200, Wolfgang Denk wrote:
> Dear York Sun,
>
> In message <1314378058.20734.25.camel@oslab-l1> you wrote:
> >
> > I am going to follow the style and not to add new typedefs. For the
> > existing typedef, I will keep using them. In this case, it is an
> > existing typedef, just for another platform. Fixing it alone will cause
> > more troubles.
>
> I understand why you would prefer such an interpretation... But the
> fact is, you are adding new code that contains typedef's (and it does
> not matter at all if other code in other places does the same or not).
>
>
> Please don't misunderstand me - I can accept if you prefer not to fix
> this problem now, but rather address it later, in a separate patch.
> But it is technically wrong to claim you were not adding new
> typedef's. Checkpatch complains not without reason.
>
OK. I do prefer not to fix it now if you can accept it. Are you implying
we should fix all the existing typedefs? That will be a lot of cleanup.
York
next prev parent reply other threads:[~2011-08-26 18:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 20:50 [U-Boot] [PATCH 1/7] powerpc/mpc8xxx: Fix DDR code for empty first DIMM slot and enable DQS_en York Sun
2011-08-09 20:50 ` [U-Boot] [PATCH 2/7] powerpc/mpc8xxx: Add SPD EEPROM address for single controller 2 slots York Sun
2011-08-09 20:50 ` [U-Boot] [PATCH 3/7] powerpc/mpc8xxx: Fix picos_to_mclk() and get_memory_clk_period_ps() York Sun
2011-08-09 20:50 ` [U-Boot] [PATCH 4/7] powerpc/mpc8xxx: Add DDR2 to unified DDR driver York Sun
2011-08-09 20:50 ` [U-Boot] [PATCH 5/7] powerpc/mpc83xx: Migrate from spd_sdram " York Sun
2011-08-24 22:36 ` Wolfgang Denk
2011-08-25 20:57 ` York Sun
2011-08-25 21:20 ` Wolfgang Denk
2011-08-25 21:25 ` York Sun
2011-08-25 21:30 ` Wolfgang Denk
2011-08-25 21:36 ` York Sun
2011-08-25 22:31 ` Wolfgang Denk
2011-08-26 17:00 ` York Sun
2011-08-26 18:12 ` Wolfgang Denk
2011-08-26 18:15 ` York Sun [this message]
2011-08-09 20:50 ` [U-Boot] [PATCH 6/7] powerpc/mpc8349emds: " York Sun
2011-08-24 22:39 ` Wolfgang Denk
2011-08-09 20:50 ` [U-Boot] [PATCH 7/7] powerpc/8xxx: Add support for interactive DDR programming interface York Sun
2011-08-11 1:29 ` [U-Boot] [u-boot-release] " Tabi Timur-B04825
2011-08-24 22:33 ` [U-Boot] " Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314382529.20734.34.camel@oslab-l1 \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox