From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/5] NAND: Allow per-buffer allocation
Date: Thu, 8 Sep 2011 22:39:38 +0200 [thread overview]
Message-ID: <1315514380-19089-4-git-send-email-marek.vasut@gmail.com> (raw)
In-Reply-To: <1315514380-19089-1-git-send-email-marek.vasut@gmail.com>
Don't allocate NAND buffers as one block, but allocate them separately. This
allows systems where DMA to buffers happen to allocate these buffers properly
aligned.
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Scott Wood <scottwood@freescale.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Detlev Zundel <dzu@denx.de>
---
drivers/mtd/nand/nand_base.c | 30 +++++++++++++++++++++++-------
include/linux/mtd/nand.h | 7 ++++---
2 files changed, 27 insertions(+), 10 deletions(-)
diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index d8d30e3..3093067 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -2749,13 +2749,27 @@ int nand_scan_ident(struct mtd_info *mtd, int maxchips,
*/
int nand_scan_tail(struct mtd_info *mtd)
{
- int i;
+ int i, bufsize;
+ uint8_t *buf;
struct nand_chip *chip = mtd->priv;
- if (!(chip->options & NAND_OWN_BUFFERS))
- chip->buffers = kmalloc(sizeof(*chip->buffers), GFP_KERNEL);
- if (!chip->buffers)
- return -ENOMEM;
+ if (!(chip->options & NAND_OWN_BUFFERS)) {
+ chip->buffers = malloc(sizeof(struct nand_buffers));
+ if (!chip->buffers)
+ return -ENOMEM;
+
+ bufsize = NAND_MAX_PAGESIZE + (3 * NAND_MAX_OOBSIZE);
+ buf = malloc(bufsize);
+ if (!buf) {
+ free(chip->buffers);
+ return -ENOMEM;
+ }
+
+ chip->buffers->buffer = buf;
+ chip->buffers->ecccalc = buf;
+ chip->buffers->ecccode = buf + NAND_MAX_OOBSIZE;
+ chip->buffers->databuf = buf + (2 * NAND_MAX_OOBSIZE);
+ }
/* Set the internal oob buffer location, just after the page data */
chip->oob_poi = chip->buffers->databuf + mtd->writesize;
@@ -2996,6 +3010,8 @@ void nand_release(struct mtd_info *mtd)
/* Free bad block table memory */
kfree(chip->bbt);
- if (!(chip->options & NAND_OWN_BUFFERS))
- kfree(chip->buffers);
+ if (!(chip->options & NAND_OWN_BUFFERS)) {
+ free(chip->buffers->buffer);
+ free(chip->buffers);
+ }
}
diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
index 987a2ec..c3449a9 100644
--- a/include/linux/mtd/nand.h
+++ b/include/linux/mtd/nand.h
@@ -370,9 +370,10 @@ struct nand_ecc_ctrl {
* consecutive order.
*/
struct nand_buffers {
- uint8_t ecccalc[NAND_MAX_OOBSIZE];
- uint8_t ecccode[NAND_MAX_OOBSIZE];
- uint8_t databuf[NAND_MAX_PAGESIZE + NAND_MAX_OOBSIZE];
+ uint8_t *buffer;
+ uint8_t *ecccalc;
+ uint8_t *ecccode;
+ uint8_t *databuf;
};
/**
--
1.7.5.4
next prev parent reply other threads:[~2011-09-08 20:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 20:39 [U-Boot] [PATCH 0/5] Random NAND fixes and improvements Marek Vasut
2011-09-08 20:39 ` [U-Boot] [PATCH 1/5] NAND: Really ignore bad blocks when scrubbing Marek Vasut
2011-09-08 20:39 ` [U-Boot] [PATCH 2/5] NAND: Add nand read.raw and write.raw commands Marek Vasut
2011-09-08 20:39 ` Marek Vasut [this message]
2011-09-08 20:39 ` [U-Boot] [PATCH 4/5] NAND: Make page, erase, oob size available via cmd_nand Marek Vasut
2011-09-08 20:39 ` [U-Boot] [PATCH 5/5] NAND: Add scrub.quiet command option Marek Vasut
2011-09-09 15:39 ` Detlev Zundel
2011-09-10 20:54 ` Marek Vasut
2011-09-12 9:49 ` Detlev Zundel
-- strict thread matches above, loose matches on Subject: below --
2011-09-12 4:04 [U-Boot] [PATCH 0/5 V2] Random NAND fixes and improvements Marek Vasut
2011-09-12 4:04 ` [U-Boot] [PATCH 3/5] NAND: Allow per-buffer allocation Marek Vasut
2011-09-21 18:50 ` Scott Wood
2011-09-21 19:49 ` Wolfgang Denk
2011-09-21 19:55 ` Scott Wood
2011-09-21 20:16 ` Wolfgang Denk
2011-09-22 1:34 ` Marek Vasut
2011-09-22 7:41 ` Stefano Babic
2011-09-22 8:51 ` Marek Vasut
2011-09-23 17:35 ` Scott Wood
2011-09-24 12:37 ` Marek Vasut
2011-09-26 18:33 ` Scott Wood
2011-09-26 18:49 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315514380-19089-4-git-send-email-marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox