public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ATA: Squash warnings in mxc_ata.
Date: Fri, 23 Sep 2011 11:12:11 +0200	[thread overview]
Message-ID: <1316769132-20368-1-git-send-email-marek.vasut@gmail.com> (raw)

mxc_ata.c: In function ?set_ata_bus_timing?:
mxc_ata.c:118: warning: dereferencing type-punned pointer will break
strict-aliasing rules
mxc_ata.c:125: warning: dereferencing type-punned pointer will break
strict-aliasing rules
mxc_ata.c:129: warning: dereferencing type-punned pointer will break
strict-aliasing rules

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Stefano Babic <sbabic@denx.de>
---
 drivers/block/mxc_ata.c |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/block/mxc_ata.c b/drivers/block/mxc_ata.c
index f22f4f4..d94ec9c 100644
--- a/drivers/block/mxc_ata.c
+++ b/drivers/block/mxc_ata.c
@@ -98,6 +98,7 @@ static void set_ata_bus_timing(unsigned char mode)
 {
 	uint32_t val;
 	uint32_t T = 1000000000 / mxc_get_clock(MXC_IPG_CLK);
+	uint32_t reg;
 
 	struct mxc_ata_config_regs *ata_regs;
 	ata_regs = (struct mxc_ata_config_regs *)CONFIG_SYS_ATA_BASE_ADDR;
@@ -106,22 +107,25 @@ static void set_ata_bus_timing(unsigned char mode)
 		return;
 
 	/* Write TIME_OFF/ON/1/2W */
+	reg = (uint32_t)&ata_regs->time_off;
 	val =	(3 << REG2OFF(&ata_regs->time_off)) |
 		(3 << REG2OFF(&ata_regs->time_on)) |
 		(((pio_t1[mode] + T) / T) << REG2OFF(&ata_regs->time_1)) |
 		(((pio_t2_8[mode] + T) / T) << REG2OFF(&ata_regs->time_2w));
-	writel(val, &ata_regs->time_off);
+	writel(val, reg);
 
 	/* Write TIME_2R/AX/RDX/4 */
+	reg = (uint32_t)&ata_regs->time_2r;
 	val =	(((pio_t2_8[mode] + T) / T) << REG2OFF(&ata_regs->time_2r)) |
 		(((pio_tA[mode] + T) / T + 2) << REG2OFF(&ata_regs->time_ax)) |
 		(1 << REG2OFF(&ata_regs->time_pio_rdx)) |
 		(((pio_t4[mode] + T) / T) << REG2OFF(&ata_regs->time_4));
-	writel(val, &ata_regs->time_2r);
+	writel(val, reg);
 
 	/* Write TIME_9 ; the rest of timing registers is irrelevant for PIO */
+	reg = (uint32_t)&ata_regs->time_9;
 	val =	(((pio_t9[mode] + T) / T) << REG2OFF(&ata_regs->time_9));
-	writel(val, &ata_regs->time_9);
+	writel(val, reg);
 }
 
 int ide_preinit(void)
-- 
1.7.5.4

             reply	other threads:[~2011-09-23  9:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-23  9:12 Marek Vasut [this message]
2011-09-23  9:27 ` [U-Boot] [PATCH] ATA: Squash warnings in mxc_ata Stefano Babic
2011-09-23  9:42 ` [U-Boot] [PATCH V2] " Marek Vasut
2011-09-23 10:02   ` Stefano Babic
2011-09-23 10:04   ` [U-Boot] [PATCH V3] " Marek Vasut
2011-09-25 17:21     ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316769132-20368-1-git-send-email-marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox