From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/7] GCC4.6: Squash warning in cmd_flash.c
Date: Mon, 26 Sep 2011 02:26:02 +0200 [thread overview]
Message-ID: <1316996766-14248-3-git-send-email-marek.vasut@gmail.com> (raw)
In-Reply-To: <1316996766-14248-1-git-send-email-marek.vasut@gmail.com>
cmd_flash.c: In function ?do_protect?:
cmd_flash.c:474:6: warning: variable ?p? set but not used
[-Wunused-but-set-variable]
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
---
common/cmd_flash.c | 10 ++++++----
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/common/cmd_flash.c b/common/cmd_flash.c
index 5508d73..6765347 100644
--- a/common/cmd_flash.c
+++ b/common/cmd_flash.c
@@ -455,6 +455,7 @@ int flash_sect_erase (ulong addr_first, ulong addr_last)
int do_protect (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{
+ int rcode = 0;
#ifndef CONFIG_SYS_NO_FLASH
flash_info_t *info;
ulong bank;
@@ -465,24 +466,25 @@ int do_protect (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
u8 dev_type, dev_num, pnum;
#endif
#endif /* CONFIG_SYS_NO_FLASH */
-#if !defined(CONFIG_SYS_NO_FLASH) || defined(CONFIG_HAS_DATAFLASH)
- ulong addr_first, addr_last;
-#endif
#ifdef CONFIG_HAS_DATAFLASH
int status;
#endif
+#if !defined(CONFIG_SYS_NO_FLASH) || defined(CONFIG_HAS_DATAFLASH)
int p;
- int rcode = 0;
+ ulong addr_first, addr_last;
+#endif
if (argc < 3)
return cmd_usage(cmdtp);
+#if !defined(CONFIG_SYS_NO_FLASH) || defined(CONFIG_HAS_DATAFLASH)
if (strcmp(argv[1], "off") == 0)
p = 0;
else if (strcmp(argv[1], "on") == 0)
p = 1;
else
return cmd_usage(cmdtp);
+#endif
#ifdef CONFIG_HAS_DATAFLASH
if ((strcmp(argv[2], "all") != 0) && (strcmp(argv[2], "bank") != 0)) {
--
1.7.5.4
next prev parent reply other threads:[~2011-09-26 0:26 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 0:26 [U-Boot] [PATCH 1/7 V2] GCC4.6: Convert various empty macros to inline functions Marek Vasut
2011-09-26 0:26 ` [U-Boot] [PATCH 2/7 RESEND] GCC4.6: Remove unused "port" variable in cmd_usb.c Marek Vasut
2011-09-26 3:40 ` Mike Frysinger
2011-09-26 0:26 ` Marek Vasut [this message]
2011-10-01 21:25 ` [U-Boot] [PATCH 3/7] GCC4.6: Squash warning in cmd_flash.c Wolfgang Denk
2011-09-26 0:26 ` [U-Boot] [PATCH 4/7] GCC4.6: Squash warning in cmd_nvedit.c Marek Vasut
2011-09-26 3:39 ` Mike Frysinger
2011-09-26 3:40 ` Mike Frysinger
2011-09-26 18:15 ` Simon Glass
2011-10-01 21:26 ` Wolfgang Denk
2011-09-26 0:26 ` [U-Boot] [PATCH 5/7] GCC4.6: Squash warnings in lcd.c Marek Vasut
2011-10-01 21:26 ` Wolfgang Denk
2011-09-26 0:26 ` [U-Boot] [PATCH 6/7] GCC4.6: Squash warnings in ipu_disp.c Marek Vasut
2011-10-01 21:27 ` Wolfgang Denk
2011-09-26 0:26 ` [U-Boot] [PATCH 7/7] GCC4.6: Squash warning in cmd_mem.c Marek Vasut
2011-09-26 3:41 ` Mike Frysinger
2011-09-26 7:25 ` Wolfgang Denk
2011-09-26 9:03 ` Marek Vasut
2011-09-26 16:10 ` Mike Frysinger
2011-09-26 17:31 ` Marek Vasut
2011-09-26 18:03 ` Wolfgang Denk
2011-09-26 18:29 ` Marek Vasut
2011-09-26 18:49 ` Wolfgang Denk
2011-09-26 19:52 ` Mike Frysinger
2011-09-26 18:05 ` Simon Glass
2011-09-26 18:24 ` Marek Vasut
2011-09-26 18:29 ` Simon Glass
2011-09-26 18:34 ` Marek Vasut
2011-09-26 19:01 ` Simon Glass
2011-09-26 19:10 ` Marek Vasut
2011-09-26 19:13 ` Simon Glass
2011-10-01 21:27 ` Wolfgang Denk
2011-09-26 2:39 ` [U-Boot] [PATCH 1/7 V2] GCC4.6: Convert various empty macros to inline functions Fabio Estevam
2011-09-26 9:04 ` Marek Vasut
2011-09-26 11:28 ` Wolfgang Denk
2011-09-26 3:41 ` Mike Frysinger
2011-09-26 17:36 ` [U-Boot] [PATCH 1/7 V3] " Marek Vasut
2011-10-01 21:20 ` Wolfgang Denk
2011-10-02 18:36 ` Wolfgang Denk
2011-10-02 19:08 ` Marek Vasut
2011-10-02 22:50 ` Marek Vasut
2011-10-03 18:32 ` [U-Boot] [PATCH 1/7 V2] " Marek Vasut
2011-10-03 18:36 ` Wolfgang Denk
2011-10-03 18:42 ` Marek Vasut
2011-10-03 22:58 ` Marek Vasut
2011-10-04 12:18 ` Marek Vasut
2011-10-04 19:06 ` Marek Vasut
2011-10-04 19:23 ` Wolfgang Denk
2011-10-04 19:46 ` Mike Frysinger
2011-10-04 20:44 ` Wolfgang Denk
2011-10-04 20:58 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316996766-14248-3-git-send-email-marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox