public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/7 V3] GCC4.6: Convert various empty macros to inline functions
Date: Mon, 26 Sep 2011 19:36:19 +0200	[thread overview]
Message-ID: <1317058579-936-1-git-send-email-marek.vasut@gmail.com> (raw)
In-Reply-To: <1316996766-14248-1-git-send-email-marek.vasut@gmail.com>

Fix the following gcc4.6 problems:

cmd_date.c: In function ?do_date?:
cmd_date.c:50:6: warning: variable ?old_bus? set but not used
[-Wunused-but-set-variable]
asix.c: In function ?asix_init?:
asix.c:317:6: warning: variable ?rx_ctl? set but not used
[-Wunused-but-set-variable]
usb.c: In function ?usb_parse_config?:
usb.c:331:17: warning: variable ?ch? set but not used
[-Wunused-but-set-variable]
usb.c: In function ?usb_hub_port_connect_change?:
usb.c:1123:29: warning: variable ?portchange? set but not used
[-Wunused-but-set-variable]
usb.c: In function ?usb_hub_configure?:
usb.c:1183:25: warning: variable ?hubsts? set but not used
[-Wunused-but-set-variable]
usb_storage.c: In function ?usb_stor_CB_reset?:
usb_storage.c:466:6: warning: variable ?result? set but not used
[-Wunused-but-set-variable]

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
---
 common/usb.c         |    4 ++--
 common/usb_storage.c |    2 +-
 include/common.h     |    4 ++--
 include/i2c.h        |    5 ++++-
 4 files changed, 9 insertions(+), 6 deletions(-)

V2: Squash warning in usb_storage.c
V3: update diff description

diff --git a/common/usb.c b/common/usb.c
index a401c09..a5f9e9f 100644
--- a/common/usb.c
+++ b/common/usb.c
@@ -63,7 +63,7 @@
 #ifdef	USB_DEBUG
 #define	USB_PRINTF(fmt, args...)	printf(fmt , ##args)
 #else
-#define USB_PRINTF(fmt, args...)
+static inline void USB_PRINTF(const char *fmt, ...) {}
 #endif
 
 #define USB_BUFSIZ	512
@@ -970,7 +970,7 @@ void usb_scan_devices(void)
 #ifdef	USB_HUB_DEBUG
 #define	USB_HUB_PRINTF(fmt, args...)	printf(fmt , ##args)
 #else
-#define USB_HUB_PRINTF(fmt, args...)
+static inline void USB_HUB_PRINTF(const char *fmt, ...) {}
 #endif
 
 
diff --git a/common/usb_storage.c b/common/usb_storage.c
index 16667f3..5c56918 100644
--- a/common/usb_storage.c
+++ b/common/usb_storage.c
@@ -63,7 +63,7 @@
 #ifdef	USB_STOR_DEBUG
 #define USB_STOR_PRINTF(fmt, args...)	printf(fmt , ##args)
 #else
-#define USB_STOR_PRINTF(fmt, args...)
+static inline void USB_STOR_PRINTF(const char *fmt, ...) {}
 #endif
 
 #include <scsi.h>
diff --git a/include/common.h b/include/common.h
index d244bd4..aeb2d84 100644
--- a/include/common.h
+++ b/include/common.h
@@ -120,8 +120,8 @@ typedef volatile unsigned char	vu_char;
 #define debug(fmt,args...)	printf (fmt ,##args)
 #define debugX(level,fmt,args...) if (DEBUG>=level) printf(fmt,##args);
 #else
-#define debug(fmt,args...)
-#define debugX(level,fmt,args...)
+static inline void debug(const char *fmt, ...) {}
+static inline void debugX(int level, const char *fmt, ...) {}
 #endif	/* DEBUG */
 
 #ifdef DEBUG
diff --git a/include/i2c.h b/include/i2c.h
index 8ceb4c8..323150d 100644
--- a/include/i2c.h
+++ b/include/i2c.h
@@ -55,7 +55,10 @@
 #else
 #define CONFIG_SYS_MAX_I2C_BUS		1
 #define I2C_GET_BUS()		0
-#define I2C_SET_BUS(a)
+static inline int I2C_SET_BUS(unsigned int bus)
+{
+	return 0;
+}
 #endif
 
 /* define the I2C bus number for RTC and DTT if not already done */
-- 
1.7.5.4

  parent reply	other threads:[~2011-09-26 17:36 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-26  0:26 [U-Boot] [PATCH 1/7 V2] GCC4.6: Convert various empty macros to inline functions Marek Vasut
2011-09-26  0:26 ` [U-Boot] [PATCH 2/7 RESEND] GCC4.6: Remove unused "port" variable in cmd_usb.c Marek Vasut
2011-09-26  3:40   ` Mike Frysinger
2011-09-26  0:26 ` [U-Boot] [PATCH 3/7] GCC4.6: Squash warning in cmd_flash.c Marek Vasut
2011-10-01 21:25   ` Wolfgang Denk
2011-09-26  0:26 ` [U-Boot] [PATCH 4/7] GCC4.6: Squash warning in cmd_nvedit.c Marek Vasut
2011-09-26  3:39   ` Mike Frysinger
2011-09-26  3:40   ` Mike Frysinger
2011-09-26 18:15   ` Simon Glass
2011-10-01 21:26   ` Wolfgang Denk
2011-09-26  0:26 ` [U-Boot] [PATCH 5/7] GCC4.6: Squash warnings in lcd.c Marek Vasut
2011-10-01 21:26   ` Wolfgang Denk
2011-09-26  0:26 ` [U-Boot] [PATCH 6/7] GCC4.6: Squash warnings in ipu_disp.c Marek Vasut
2011-10-01 21:27   ` Wolfgang Denk
2011-09-26  0:26 ` [U-Boot] [PATCH 7/7] GCC4.6: Squash warning in cmd_mem.c Marek Vasut
2011-09-26  3:41   ` Mike Frysinger
2011-09-26  7:25     ` Wolfgang Denk
2011-09-26  9:03       ` Marek Vasut
2011-09-26 16:10         ` Mike Frysinger
2011-09-26 17:31           ` Marek Vasut
2011-09-26 18:03             ` Wolfgang Denk
2011-09-26 18:29               ` Marek Vasut
2011-09-26 18:49                 ` Wolfgang Denk
2011-09-26 19:52                 ` Mike Frysinger
2011-09-26 18:05   ` Simon Glass
2011-09-26 18:24     ` Marek Vasut
2011-09-26 18:29       ` Simon Glass
2011-09-26 18:34         ` Marek Vasut
2011-09-26 19:01           ` Simon Glass
2011-09-26 19:10             ` Marek Vasut
2011-09-26 19:13               ` Simon Glass
2011-10-01 21:27   ` Wolfgang Denk
2011-09-26  2:39 ` [U-Boot] [PATCH 1/7 V2] GCC4.6: Convert various empty macros to inline functions Fabio Estevam
2011-09-26  9:04   ` Marek Vasut
2011-09-26 11:28     ` Wolfgang Denk
2011-09-26  3:41 ` Mike Frysinger
2011-09-26 17:36 ` Marek Vasut [this message]
2011-10-01 21:20   ` [U-Boot] [PATCH 1/7 V3] " Wolfgang Denk
2011-10-02 18:36     ` Wolfgang Denk
2011-10-02 19:08       ` Marek Vasut
2011-10-02 22:50         ` Marek Vasut
2011-10-03 18:32 ` [U-Boot] [PATCH 1/7 V2] " Marek Vasut
2011-10-03 18:36   ` Wolfgang Denk
2011-10-03 18:42     ` Marek Vasut
2011-10-03 22:58       ` Marek Vasut
2011-10-04 12:18     ` Marek Vasut
2011-10-04 19:06       ` Marek Vasut
2011-10-04 19:23         ` Wolfgang Denk
2011-10-04 19:46         ` Mike Frysinger
2011-10-04 20:44           ` Wolfgang Denk
2011-10-04 20:58             ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1317058579-936-1-git-send-email-marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox