[U-Boot] some USB cleanup on EfikaMX

Wolfgang Denk
2011-09-08T22:32:02Z

Dear Jana Rapava,

In message <CAB+7RbE2MXooOuN3pniuBw7+K71Q0avCfxzuZXuBFfCZpvdctA@mail.gmail.com> you wrote:
> --===============1315613369==
> Content-Type: multipart/alternative; boundary=00151744109ca7dd4e04ac7470e6
>
> --00151744109ca7dd4e04ac7470e6
> Content-Type: text/plain; charset=ISO-8859-1

Please resubmit as a proper patch.
See http://www.denx.de/wiki/U-Boot/Patches for instructions.

Most important: your signed-off-by: line is missing, as is a
descriptionof which specific problem you are fixing.

> --- a/board/efikamx/efikamx-usb.c
> +++ b/board/efikamx/efikamx-usb.c
> @@ -154,6 +154,7 @@ void efika_usb_phy_reset(void)
> gpio_set_value(IOMUX_TO_GPIO(MX51_PIN_EIM_D27), 1);
> }
>
> +

Please do not add random (and excessive) white space.

> + tmp = readl(OTG_BASE_ADDR + MX51_USB_CTRL_OFFSET);
> + tmp &= ~(MX51_OTG_WUE_BIT | MX51_OTG_PM_BIT | MX51_H1_ULPI_IE_BIT |
> MX51_H1_WUE_BIT);

Your mailer line-wrapped your patch and thus corrupted it. Please
make sure to configure your mailer not to do that. Even better, use
"git format-patch" to create hte patch and "git send-email" to submit
it.

> - tmp = readl(OTG_BASE_ADDR + 0x808);
> - tmp &= ~(1 << 8);
> - tmp |= 1 << 5;
> - writel(tmp, OTG_BASE_ADDR + 0x808);
> + tmp = readl(OTG_BASE_ADDR + MX51_PHY_CTRL0_OFFSET);
> + tmp &= ~MX51_OTG_OVERCURD_BIT;
> + tmp |= MX51_EHCI_POWERPINSE_BIT;
> + writel(tmp, OTG_BASE_ADDR + MX51_PHY_CTRL0_OFFSET);

Please consider using clrsetbits_le32() here instead.

Please fix globally.

Thanks.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
This cultural mystique surrounding the biological function -- you
realize humans are overly preoccupied with the subject.
-- Kelinda the Kelvan, "By Any Other Name", stardate 4658.9