[U-Boot] [PATCH v4 4/4] Add USB support for Efika

Jana Rapava
2011-09-26T20:28:17Z

> > + while (--timeout) {
> > + tmp = readl(&ehci->ulpi_viewpoint);
> > + if (!(tmp & ulpi_bit))
> > + break;
> > + WATCHDOG_RESET();
> > + }
> > + if (!timeout) {
> > + printf("ULPI %s timed out\n", operation);
> > + return 0;
> > + }
> > + return tmp;
> > +}
> > +
> > +void ulpi_write(u8 *reg, u32 value, struct usb_ehci *ehci)
>
> ulpi_write(ehci, reg, value), please fix globally and in similar functions.
>
> Also, change u8 *reg to u8 reg, why are you passing a pointer?
>

Is it really important in ulpi_read/write function to use u8 reg instead of
u8 *reg?
When I rewrite this, usb reset starts giving me ULPI operations timeout, and
I couldn't find a source of that.
The problem is in the middle of usb_new_device, but it looks like no
function calling ULPI operations is called from that function.

Regards,
Jana Rapava