[U-Boot] [PATCH v7 4/4] Add USB support for Efika

Jana Rapava
2011-09-28T12:25:14Z

2011/9/28 Marek Vasut <marek.vasut.n900@gmail.com>

> > + /* get ID from ULPI immediate registers */
> > + for (reg = ULPI_ID_REGS_COUNT - 1; reg >= 0; reg--)
> > + tmp |= ulpi_read(ehci, (u32)reg) << (reg * 8);
>
> Are you ignoring my comment and picking only some of them? Is the cast here
> necessary?
>

Sorry, I try to change patches according to your requests, but sometimes I
overlook something.
Also, it looks like I forgot to add proper header to efikamx-usb.c. Should I
add it in the next version?

>
> > + /* USB 2.0 specification say 50 ms resets on root. */
>
> Where can I read about this please?
>

Universal Serial Bus Specification Revision 2.0, chapter 7.1.7.5 Reset
Signaling says: "It is required that resets from root ports have a duration
of at least 50 ms (TDRSTR)."

Regards,
Jana Rapava