From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marek.vasut.n900@gmail.com>
Date: Thu, 29 Sep 2011 12:47:06 +0200
Subject: [U-Boot] [PATCH v4 4/4] usb: add USB support for Efika
In-Reply-To: <1317292249-2791-1-git-send-email-fermata7@gmail.com>
References: <1317291086-2496-1-git-send-email-fermata7@gmail.com>
	<1317292249-2791-1-git-send-email-fermata7@gmail.com>
Message-ID: <1317293226.4023.8.camel@konomi>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> This commit adds USB support for EfikaMX and EfikaSB.
> 
> Signed-off-by: Jana Rapava <fermata7@gmail.com>
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> Cc: Remy Bohmer <linux@bohmer.net>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
> Changes for v2:
>? ? ? ? ? ?  - introduce temporary variable in ulpi_write
>? ? ? ? ? ?  - whitespace changes
> Changes for v3:
>? ? ? ? ? ? ?  - add protection against multiple inclusion of efika.h
> Changes for v4:
> ??? - rename multiple inclusion protection macro in efika.h
> 
>?  board/efikamx/Makefile? ? ? ? ?  |? ? ?  3 +
>?  board/efikamx/efika.h? ? ? ? ? ?  |? ?  33 ++++
>?  board/efikamx/efikamx-usb.c |?  423
> +++++++++++++++++++++++++++++++++++++++++++ board/efikamx/efikamx.c? ? ?  
> |? ? ?  3 + include/configs/efikamx.h? ?  |? ?  16 ++
>?  5 files changed, 478 insertions(+), 0 deletions(-)
>?  create mode 100644 board/efikamx/efika.h
>?  create mode 100644 board/efikamx/efikamx-usb.c
>

Dear Jana Rapava, 

[...]

> +#ifndef __BOARD_EFIKAMX_EFIKA_H__
> +#define __BOARD_EFIKAMX_EFIKA_H__
> +
> +/*
> + * EHCI USB
> + */
> +#ifdef??? CONFIG_CMD_USB
> +void setup_iomux_usb(void);
> +#else
> +static inline void setup_iomux_usb(void) { }
> +#endif

Is the ifndef actually unterminated? Did you even compile-test this?