From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/8] PPC: Fix i82365.c by removing ifdef around "buf"
Date: Mon, 3 Oct 2011 02:57:25 +0200 [thread overview]
Message-ID: <1317603450-7527-4-git-send-email-marek.vasut@gmail.com> (raw)
In-Reply-To: <1317603450-7527-1-git-send-email-marek.vasut@gmail.com>
From: Marek Vasut <marex@pollux.denx.de>
As the "buf" is cleared at runtime, this might introduce a slight overhead.
Signed-off-by: Marek Vasut <marex@pollux.denx.de>
---
drivers/pcmcia/i82365.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
Q: Can this be squashed into char buf[200] = {0}; ? That'd help the
optimization to remove the overhead altogether again.
diff --git a/drivers/pcmcia/i82365.c b/drivers/pcmcia/i82365.c
index 1bcb3a5..968d35a 100644
--- a/drivers/pcmcia/i82365.c
+++ b/drivers/pcmcia/i82365.c
@@ -272,11 +272,9 @@ static u_int cirrus_set_opts (socket_info_t * s)
{
cirrus_state_t *p = &s->c_state;
u_int mask = 0xffff;
-#if DEBUG
char buf[200];
memset (buf, 0, 200);
-#endif
if (has_ring == -1)
has_ring = 1;
--
1.7.6.2
next prev parent reply other threads:[~2011-10-03 0:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 0:57 [U-Boot] [PATCH 0/8] Fix PPC issues introduced by debug() macro change Marek Vasut
2011-10-03 0:57 ` [U-Boot] [PATCH 1/8] PPC: Fix tqm8xx_pcmcia.c by removing condition around pcmp Marek Vasut
2011-10-03 14:26 ` Wolfgang Denk
2011-10-03 0:57 ` [U-Boot] [PATCH 2/8] PPC: Fix mem_to_mem_idma2intr.c by renaming "debug" to "mmdebug" Marek Vasut
2011-10-03 14:28 ` Wolfgang Denk
2011-10-03 0:57 ` Marek Vasut [this message]
2011-10-03 14:29 ` [U-Boot] [PATCH 3/8] PPC: Fix i82365.c by removing ifdef around "buf" Wolfgang Denk
2011-10-03 0:57 ` [U-Boot] [PATCH 4/8] PPC: Fix relative path in galileo/core.h Marek Vasut
2011-10-03 14:31 ` Wolfgang Denk
2011-10-03 14:46 ` Marek Vasut
2011-10-03 0:57 ` [U-Boot] [PATCH 5/8] PPC: Fix pd67290.c by removing ifdef around "buf" Marek Vasut
2011-10-03 14:32 ` Wolfgang Denk
2011-10-03 0:57 ` [U-Boot] [PATCH 6/8] PPC: Fix eepro100_eeprom.c by renaming "debug" to "eedebug" Marek Vasut
2011-10-03 14:34 ` Wolfgang Denk
2011-10-03 0:57 ` [U-Boot] [PATCH 7/8] PPC: Fix fsl_upm.c by renaming nand handling functions Marek Vasut
2011-10-03 14:35 ` Wolfgang Denk
2011-10-03 0:57 ` [U-Boot] [PATCH 8/8] PPC: Remove #ifdef DEBUG around step_to_string Marek Vasut
2011-10-03 14:39 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317603450-7527-4-git-send-email-marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox