public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jon Medhurst (Tixy) <jon.medhurst@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MMC: PL180: Fix infinite loop with VExpress extended fifo implementation
Date: Wed, 05 Oct 2011 10:48:45 +0100	[thread overview]
Message-ID: <1317808125.2207.9.camel@linaro1> (raw)
In-Reply-To: <1317807029.3158.346.camel@hornet.cambridge.arm.com>

On Wed, 2011-10-05 at 10:30 +0100, Pawel Moll wrote:
> Hi Tixy,
> 
> > One possible fix is to add some build time configuration to change
> > SDI_FIFO_BURST_SIZE for the new implementation. 
> 
> You can also detect the configuration in runtime, basing on PeriphID:
> 
> http://infocenter.arm.com/help/topic/com.arm.doc.ddi0172a/i1024149.html
> 
> Configuration == 0 (ID == 0x00041180) -> FIFO length = 16 * 4
> Configuration == 1 (ID == 0x01041180) -> FIFO length = 128 * 4

That's useful to know. The PL180 code is also used for U8500, I don't
know if that implements the peripheral ID register; though I guess any
probing could be limited to vexpress anyway.

However, I think that if smaller and simpler code will work on all
hardware then that is preferable.

-- 
Tixy

  reply	other threads:[~2011-10-05  9:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-04 17:32 [U-Boot] [PATCH] MMC: PL180: Fix infinite loop with VExpress extended fifo implementation Jon Medhurst
2011-10-05  9:30 ` Pawel Moll
2011-10-05  9:48   ` Jon Medhurst [this message]
2011-10-05  9:58     ` Pawel Moll
2011-10-05 10:14       ` Jon Medhurst
2011-10-06 16:43 ` Matt Waddel
2011-11-03  1:39 ` Andy Fleming
2011-11-04 13:06   ` [U-Boot] [PATCH v2] " Jon Medhurst
2011-11-08 20:46     ` Andy Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1317808125.2207.9.camel@linaro1 \
    --to=jon.medhurst@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox