From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Medhurst (Tixy) Date: Wed, 05 Oct 2011 10:48:45 +0100 Subject: [U-Boot] [PATCH] MMC: PL180: Fix infinite loop with VExpress extended fifo implementation In-Reply-To: <1317807029.3158.346.camel@hornet.cambridge.arm.com> References: <1317749544.740.27.camel@linaro1> <1317807029.3158.346.camel@hornet.cambridge.arm.com> Message-ID: <1317808125.2207.9.camel@linaro1> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, 2011-10-05 at 10:30 +0100, Pawel Moll wrote: > Hi Tixy, > > > One possible fix is to add some build time configuration to change > > SDI_FIFO_BURST_SIZE for the new implementation. > > You can also detect the configuration in runtime, basing on PeriphID: > > http://infocenter.arm.com/help/topic/com.arm.doc.ddi0172a/i1024149.html > > Configuration == 0 (ID == 0x00041180) -> FIFO length = 16 * 4 > Configuration == 1 (ID == 0x01041180) -> FIFO length = 128 * 4 That's useful to know. The PL180 code is also used for U8500, I don't know if that implements the peripheral ID register; though I guess any probing could be limited to vexpress anyway. However, I think that if smaller and simpler code will work on all hardware then that is preferable. -- Tixy