public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut.n900@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] PPC: Cleanup tqm8xx_pcmcia.c
Date: Tue, 18 Oct 2011 11:52:20 +0200	[thread overview]
Message-ID: <1318931540.26165.2.camel@konomi> (raw)
In-Reply-To: <20111018063839.60939140797D@gemini.denx.de>

> Dear Marek Vasut,
> 
> In message <1317819115-9089-1-git-send-email-marek.vasut@gmail.com> you
> wrote:
> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> > ---
> > drivers/pcmcia/tqm8xx_pcmcia.c |?  154
> > +++++++++++++++++++++------------------- 1 files changed, 81
> > insertions(+), 73 deletions(-)
> 
> This commit causes new warnings on the virtlab2 board:
> 
> Configuring for virtlab2 board...
> tqm8xx_pcmcia.c: In function 'power_off':
> tqm8xx_pcmcia.c:46: warning: passing argument 1 of 'out_be32' makes
> pointer from integer without a cast tqm8xx_pcmcia.c: In function
> 'power_on_5_0': tqm8xx_pcmcia.c:52: warning: passing argument 1 of
> 'out_be32' makes pointer from integer without a cast tqm8xx_pcmcia.c: In
> function 'power_on_3_3': tqm8xx_pcmcia.c:58: warning: passing argument 1
> of 'out_be32' makes pointer from integer without a cast
> 
> 
> Why did you not run MAKEALL???
> 
> Please fix!
> 
> Best regards,
> 
> Wolfgang Denk

Fix for this is in my patchqueue for a while now. I'm still hunting down those +/- four byte growths/decreases though. I suspect the fact that such things happens is because the optimization graph is too complicated and gcc4.2 can't cope with it anymore.

      reply	other threads:[~2011-10-18  9:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-05 12:51 [U-Boot] [PATCH] PPC: Cleanup tqm8xx_pcmcia.c Marek Vasut
2011-10-05 12:53 ` Marek Vasut
2011-10-05 15:31   ` Wolfgang Denk
2011-10-05 18:40 ` Wolfgang Denk
2011-10-05 19:52   ` Wolfgang Denk
2011-10-05 22:17     ` Marek Vasut
2011-10-05 18:42 ` Wolfgang Denk
2011-10-05 19:55 ` [U-Boot] [PATCH] TQM8xx: make room for growing code size due to I/O accessor cleanup Wolfgang Denk
2011-10-05 19:59   ` Wolfgang Denk
2011-10-05 20:01   ` Wolfgang Denk
2011-10-05 22:16     ` Marek Vasut
2011-10-06 17:44       ` Wolfgang Denk
2011-10-18  6:38 ` [U-Boot] [PATCH] PPC: Cleanup tqm8xx_pcmcia.c Wolfgang Denk
2011-10-18  9:52   ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1318931540.26165.2.camel@konomi \
    --to=marek.vasut.n900@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox